From cd9f4ba229eb74a8fbd03a01a4ce587eca6910da Mon Sep 17 00:00:00 2001 From: Carlosbg Date: Fri, 5 Nov 2021 19:42:50 +0100 Subject: [PATCH 1/3] PR for issue #1314 --- pvlib/location.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvlib/location.py b/pvlib/location.py index 97767a5801..104fccac89 100644 --- a/pvlib/location.py +++ b/pvlib/location.py @@ -183,7 +183,7 @@ def get_solarposition(self, times, pressure=None, temperature=12, ------- solar_position : DataFrame Columns depend on the ``method`` kwarg, but always include - ``zenith`` and ``azimuth``. + ``zenith`` and ``azimuth``. The angles are in degrees. """ if pressure is None: pressure = atmosphere.alt2pres(self.altitude) From 114bfc108fab7521806419e9a87c321138ad1856 Mon Sep 17 00:00:00 2001 From: Carlosbg Date: Wed, 8 Dec 2021 20:06:02 +0100 Subject: [PATCH 2/3] Documentation: Added note to `irradiance.haydavies` docstring. Close #1352 Added a note about projection_ratio parameter to `irradiance.haydavies` docstring as mentioned by @kanderso-nrel . --- pvlib/irradiance.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pvlib/irradiance.py b/pvlib/irradiance.py index f1cc128724..5ff3fc4991 100644 --- a/pvlib/irradiance.py +++ b/pvlib/irradiance.py @@ -795,6 +795,11 @@ def haydavies(surface_tilt, surface_azimuth, dhi, dni, dni_extra, sky_diffuse : numeric The sky diffuse component of the solar radiation. + Notes + ------ + When supplying projection_ratio, consider constraining its values + when zenith angle approaches 90 degrees. See code for details. + References ----------- .. [1] Loutzenhiser P.G. et. al. "Empirical validation of models to From 611be5e2f7472a50f4a9b351d23117c223c293d0 Mon Sep 17 00:00:00 2001 From: Carlosbogo <84228424+Carlosbogo@users.noreply.github.com> Date: Thu, 9 Dec 2021 22:42:00 +0100 Subject: [PATCH 3/3] Documentation: Add note to irradiance.haydavies docstring. Update #1353 Added the changes suggested by @kanderso-nrel Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com> --- pvlib/irradiance.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pvlib/irradiance.py b/pvlib/irradiance.py index 5ff3fc4991..c5c3b1c095 100644 --- a/pvlib/irradiance.py +++ b/pvlib/irradiance.py @@ -797,8 +797,9 @@ def haydavies(surface_tilt, surface_azimuth, dhi, dni, dni_extra, Notes ------ - When supplying projection_ratio, consider constraining its values - when zenith angle approaches 90 degrees. See code for details. + When supplying ``projection_ratio``, consider constraining its values + when zenith angle approaches 90 degrees or angle of incidence + projection is negative. See code for details. References -----------