From af427151f1722915c9509d4867c080cb8b75bf9a Mon Sep 17 00:00:00 2001 From: eeshsaxena Date: Fri, 3 Jul 2026 17:32:33 +0530 Subject: [PATCH 1/3] docs: fix parameter name mismatches in docstrings - pvsystem.py: `aoi_model` -> `iam_model` in PVSystem.get_iam and Array.get_iam (signature parameter is `iam_model`) - solarposition.py: `time` -> `times` in sun_rise_set_transit_ephem - irradiance.py: _liujordan documented a nonexistent `pressure` parameter; replace with the actual `airmass` parameter - bifacial/infinite_sheds.py: remove duplicated stale Parameters block in _poa_sky_diffuse_pv (listed `f_x` and `npoints` which are not parameters of this function) --- pvlib/bifacial/infinite_sheds.py | 16 ---------------- pvlib/irradiance.py | 4 ++-- pvlib/pvsystem.py | 4 ++-- pvlib/solarposition.py | 2 +- 4 files changed, 5 insertions(+), 21 deletions(-) diff --git a/pvlib/bifacial/infinite_sheds.py b/pvlib/bifacial/infinite_sheds.py index f99c536315..77d25d3ca1 100644 --- a/pvlib/bifacial/infinite_sheds.py +++ b/pvlib/bifacial/infinite_sheds.py @@ -45,19 +45,6 @@ def _poa_sky_diffuse_pv(dhi, gcr, surface_tilt): Integrated view factors from the shaded and unshaded parts of the row slant height to the sky. - Parameters - ---------- - f_x : numeric - Fraction of row slant height from the bottom that is shaded from - direct irradiance. [unitless] - surface_tilt : numeric - Surface tilt angle in degrees from horizontal, e.g., surface facing up - = 0, surface facing horizon = 90. [degree] - gcr : float - Ratio of row slant length to row spacing (pitch). [unitless] - npoints : int, default 100 - Number of points for integration. [unitless] - A detailed calculation would be dhi * (f_x * vf_shade_sky_integ + (1 - f_x) * vf_noshade_sky_integ) @@ -73,9 +60,6 @@ def _poa_sky_diffuse_pv(dhi, gcr, surface_tilt): Parameters ---------- - f_x : numeric - Fraction of row slant height from the bottom that is shaded from - direct irradiance. [unitless] dhi : numeric Diffuse horizontal irradiance (DHI). [W/m^2] gcr : float diff --git a/pvlib/irradiance.py b/pvlib/irradiance.py index 6c39303b99..c50d795888 100644 --- a/pvlib/irradiance.py +++ b/pvlib/irradiance.py @@ -3122,8 +3122,8 @@ def _liujordan(zenith, transmittance, airmass, dni_extra=1367.0): transmittance: float Atmospheric transmittance between 0 and 1. - pressure: float, default 101325.0 - Air pressure + airmass: numeric + Optical air mass number. [unitless] dni_extra: float, default 1367.0 Direct irradiance incident at the top of the atmosphere. diff --git a/pvlib/pvsystem.py b/pvlib/pvsystem.py index 90e5193115..3e39012a8f 100644 --- a/pvlib/pvsystem.py +++ b/pvlib/pvsystem.py @@ -395,7 +395,7 @@ def get_iam(self, aoi, iam_model='physical'): aoi : numeric or tuple of numeric The angle of incidence in degrees. - aoi_model : string, default 'physical' + iam_model : string, default 'physical' The IAM model to be used. Valid strings are 'physical', 'ashrae', 'martin_ruiz', 'sapm' and 'interp'. Returns @@ -1188,7 +1188,7 @@ def get_iam(self, aoi, iam_model='physical'): aoi : numeric The angle of incidence in degrees. - aoi_model : string, default 'physical' + iam_model : string, default 'physical' The IAM model to be used. Valid strings are 'physical', 'ashrae', 'martin_ruiz', 'sapm' and 'interp'. diff --git a/pvlib/solarposition.py b/pvlib/solarposition.py index cd835e41a1..6faedbb9c7 100644 --- a/pvlib/solarposition.py +++ b/pvlib/solarposition.py @@ -516,7 +516,7 @@ def sun_rise_set_transit_ephem(times, latitude, longitude, Parameters ---------- - time : pandas.DatetimeIndex + times : pandas.DatetimeIndex Must be localized latitude : float Latitude in degrees, positive north of equator, negative to south From 3c8916330fc6cab20d7bb6db8e2e7f043c5afc44 Mon Sep 17 00:00:00 2001 From: eeshsaxena Date: Fri, 3 Jul 2026 18:31:58 +0530 Subject: [PATCH 2/3] Add contributor entry to v0.15.3 whatsnew --- docs/sphinx/source/whatsnew/v0.15.3.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew/v0.15.3.rst b/docs/sphinx/source/whatsnew/v0.15.3.rst index 87ded069ee..45b1213a45 100644 --- a/docs/sphinx/source/whatsnew/v0.15.3.rst +++ b/docs/sphinx/source/whatsnew/v0.15.3.rst @@ -42,4 +42,4 @@ Maintenance Contributors ~~~~~~~~~~~~ - +* Eesh Saxena (:ghuser:`eeshsaxena`) From 236214ebc2667734534bbaa742058425d95bc00c Mon Sep 17 00:00:00 2001 From: Kevin Anderson Date: Sat, 4 Jul 2026 14:54:50 -0400 Subject: [PATCH 3/3] Update pvlib/irradiance.py Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> --- pvlib/irradiance.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvlib/irradiance.py b/pvlib/irradiance.py index c50d795888..9db6da3aa8 100644 --- a/pvlib/irradiance.py +++ b/pvlib/irradiance.py @@ -3123,7 +3123,7 @@ def _liujordan(zenith, transmittance, airmass, dni_extra=1367.0): Atmospheric transmittance between 0 and 1. airmass: numeric - Optical air mass number. [unitless] + Optical air mass. [unitless] dni_extra: float, default 1367.0 Direct irradiance incident at the top of the atmosphere.