do not crash on __delitem__#235
Merged
Merged
Conversation
Contributor
|
Please add a test that fails before, passes after |
mildsunrise
force-pushed
the
delitem-check
branch
from
2e759a6 to
041da11
Compare
Contributor
Author
|
done. i don't think it's possible to test in a way that fails instead of invoking UB... in this case i think it's mostly guaranteed to be a crash though |
Contributor
Author
|
hello? |
Contributor
|
Thanks @mildsunrise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what it says on the tin: we're forgetting to check for deletions in many cases, so it's easy to crash the python process by doing
del pointer[slice]ordel buffer[anything]