Skip to content

Commit 0d8f6ae

Browse files
committed
New color "light green" for positive trends
to distinguish them from non-trend improvements.
1 parent 424e304 commit 0d8f6ae

2 files changed

Lines changed: 12 additions & 4 deletions

File tree

codespeed/models.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -283,17 +283,23 @@ def save(self, *args, **kwargs):
283283
self.summary = "Average %s trend %s" % (
284284
average_trend_units.lower(),
285285
self.updown(average_trend))
286-
self.colorcode = average_trend_color == "red"\
287-
and "yellow" or average_trend_color
286+
# use lighter colors for trend results:
287+
if average_trend_color == "red":
288+
self.colorcode = "yellow"
289+
elif average_trend_color == "green":
290+
self.colorcode = "lightgreen"
288291
# Single benchmark trend
289292
if max_trend_color != "none" and self.colorcode != "red":
290293
if (self.colorcode == "none" or
291294
(self.colorcode == "green" and "trend" not in self.summary)):
292295
self.summary = "%s trend %s" % (
293296
max_trend_ben,
294297
self.updown(max_trend))
295-
self.colorcode = max_trend_color == "red"\
296-
and "yellow" or max_trend_color
298+
# use lighter colors for trend results:
299+
if max_trend_color == "red":
300+
self.colorcode = "yellow"
301+
elif max_trend_color == "green":
302+
self.colorcode = "lightgreen"
297303

298304
super(Report, self).save(*args, **kwargs)
299305

codespeed/static/css/main.css

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -358,6 +358,8 @@ table.tablesorter tbody tr td.status-green, td.status-green { background-color:
358358
tr.status-green td.summary { color: #9FD54D; font-weight: bold; }
359359
table.tablesorter tbody tr td.status-yellow, td.status-yellow { background-color: #FFD843; }
360360
tr.status-yellow td.summary { color: #FFD843; font-weight: bold; }
361+
table.tablesorter tbody tr td.status-lightgreen, td.status-lightgreen { background-color: #c2e927; }
362+
tr.status-lightgreen td.summary { color: #c2e927; font-weight: bold; }
361363

362364
table.tablesorter tbody tr.highlight td, tr.highlight td {
363365
background-color: #9DADC6 !important;

0 commit comments

Comments
 (0)