Use variables for the repo type switch

Author: tobami

codespeed/commits/logs.py

@@ -8,19 +8,19 @@
 
 def get_logs(rev, startrev, update=False):
     logs = []
-
-    if rev.branch.project.repo_type == 'S':
+    project = rev.branch.project
+    if project.repo_type == project.SUBVERSION:
         from .subversion import getlogs, updaterepo
-    elif rev.branch.project.repo_type == 'M':
+    elif project.repo_type == project.MERCURIAL:
         from .mercurial import getlogs, updaterepo
-    elif rev.branch.project.repo_type == 'G':
+    elif project.repo_type == project.GIT:
         from .git import getlogs, updaterepo
-    elif rev.branch.project.repo_type == 'H':
+    elif project.repo_type == project.GITHUB:
         from .github import getlogs, updaterepo
     else:
-        if rev.branch.project.repo_type not in ("N", ""):
+        if project.repo_type not in (project.NO_LOGS, ""):
             logger.warning("Don't know how to retrieve logs from %s project",
-                           rev.branch.project.get_repo_type_display())
+                           project.get_repo_type_display())
         return logs
 
     if update:

codespeed/models.py

@@ -13,17 +13,22 @@
 
 
 class Project(models.Model):
+    NO_LOGS = 'N'
+    GIT = 'G'
+    GITHUB = 'H'
+    MERCURIAL = 'M'
+    SUBVERSION = 'S'
     REPO_TYPES = (
-        ('N', 'none'),
-        ('G', 'git'),
-        ('H', 'Github.com'),
-        ('M', 'mercurial'),
-        ('S', 'subversion'),
+        (NO_LOGS, 'none'),
+        (GIT, 'git'),
+        (GITHUB, 'Github.com'),
+        (MERCURIAL, 'mercurial'),
+        (SUBVERSION, 'subversion'),
     )
 
     name = models.CharField(unique=True, max_length=30)
     repo_type = models.CharField(
-        "Repository type", max_length=1, choices=REPO_TYPES, default='N')
+        "Repository type", max_length=1, choices=REPO_TYPES, default=NO_LOGS)
     repo_path = models.CharField("Repository URL", blank=True, max_length=200)
     repo_user = models.CharField("Repository username",
                                  blank=True, max_length=100)