Skip to content

Commit bb4e36b

Browse files
committed
Aggregate report per unit_title, not per unit
If we have several very different things (Buildtime vs. Runtime) with the same unit (seconds), we want to keep them separate.
1 parent 94ee71a commit bb4e36b

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

codespeed/models.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -366,16 +366,16 @@ def get_changes_table(self, trend_depth=10, force_save=False):
366366
)
367367

368368
tablelist = []
369-
for units in Benchmark.objects.all().values('units').distinct():
369+
for units_title in Benchmark.objects.all().values_list('units_title', flat=True).distinct():
370370
currentlist = []
371-
units_title = ""
371+
units = ""
372372
hasmin = False
373373
hasmax = False
374374
has_stddev = False
375375
smallest = 1000
376376
totals = {'change': [], 'trend': []}
377-
for bench in Benchmark.objects.filter(units=units['units']):
378-
units_title = bench.units_title
377+
for bench in Benchmark.objects.filter(units_title=units_title):
378+
units = bench.units
379379
lessisbetter = bench.lessisbetter
380380
resultquery = result_list.filter(benchmark=bench, value__gt=0)
381381
if not len(resultquery):
@@ -470,7 +470,7 @@ def get_changes_table(self, trend_depth=10, force_save=False):
470470
digits += 1
471471

472472
tablelist.append({
473-
'units': units['units'],
473+
'units': units,
474474
'units_title': units_title,
475475
'lessisbetter': lessisbetter,
476476
'has_stddev': has_stddev,

0 commit comments

Comments
 (0)