Skip to content

Commit 0df87d5

Browse files
committed
address review: check error and swap branches
1 parent 37519cf commit 0df87d5

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

Modules/mathintegermodule.c

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -484,14 +484,18 @@ _isqrt_rem(PyObject *n, PyObject **rem)
484484
Py_DECREF(tmp);
485485
}
486486
Py_SETREF(a, PyNumber_Subtract(a, _PyLong_GetOne()));
487+
if (a == NULL) {
488+
Py_DECREF(b);
489+
goto error;
490+
}
487491
}
488-
if (!rem) {
489-
Py_DECREF(b);
490-
}
491-
else {
492+
if (rem) {
492493
Py_SETREF(b, PyNumber_Subtract(n, b));
493494
*rem = b;
494495
}
496+
else {
497+
Py_DECREF(b);
498+
}
495499
Py_DECREF(n);
496500
return a;
497501

0 commit comments

Comments
 (0)