[3.14] gh-149816: add missing critical section on self in buffered_iternext (GH-150295) (#150306)

miss-islington · kumaraditya303 · web-flow · commit 2d94a6e85ed6 · 2026-05-23T14:56:44.000+05:30
gh-149816: add missing critical section on self in buffered_iternext (GH-150295) (cherry picked from commit e8545ed) Co-authored-by: Kumar Aditya <kumaraditya@python.org>
diff --git a/Modules/_io/bufferedio.c b/Modules/_io/bufferedio.c
@@ -1497,7 +1497,9 @@ buffered_iternext(PyObject *op)
         tp == state->PyBufferedRandom_Type)
     {
         /* Skip method call overhead for speed */
+        Py_BEGIN_CRITICAL_SECTION(self);
         line = _buffered_readline(self, -1);
+        Py_END_CRITICAL_SECTION();
     }
     else {
         line = PyObject_CallMethodNoArgs((PyObject *)self,

Original file line number	Diff line number	Diff line change
`@@ -1497,7 +1497,9 @@ buffered_iternext(PyObject *op)`
`1497`	`1497`	`tp == state->PyBufferedRandom_Type)`
`1498`	`1498`	`{`
`1499`	`1499`	`/* Skip method call overhead for speed */`
	`1500`	`+ Py_BEGIN_CRITICAL_SECTION(self);`
`1500`	`1501`	`line = _buffered_readline(self, -1);`
	`1502`	`+ Py_END_CRITICAL_SECTION();`
`1501`	`1503`	`}`
`1502`	`1504`	`else {`
`1503`	`1505`	`line = PyObject_CallMethodNoArgs((PyObject *)self,`