Only run on PRs + move to reusable workflow

Author: StanFromIreland

.github/workflows/reusable-check-html-ids.yml

@@ -0,0 +1,44 @@
+name: Reusable Check HTML IDs Check
+
+on:
+  workflow_call:
+
+permissions:
+  contents: read
+
+env:
+  FORCE_COLOR: 1
+
+jobs:
+  check-html-ids:
+    runs-on: ubuntu-latest
+    timeout-minutes: 30
+    steps:
+      - name: 'Check out base commit'
+        uses: actions/checkout@v6
+        with:
+          persist-credentials: false
+          ref: ${{ github.event.pull_request.base.sha }}
+      - name: 'Set up Python'
+        uses: actions/setup-python@v6
+        with:
+          python-version: '3'
+          cache: 'pip'
+          cache-dependency-path: 'Doc/requirements.txt'
+      - name: 'Install build dependencies'
+        run: make -C Doc/ venv
+      - name: 'Build HTML documentation'
+        run: make -C Doc/ SPHINXOPTS="--quiet" html
+      - name: 'Collect HTML IDs'
+        run: python Doc/tools/check-html-ids.py collect Doc/build/html -o /tmp/html-ids-base.json.gz
+      - name: 'Download PR base HTML IDs'
+        uses: actions/download-artifact@v8
+        with:
+          name: html-ids-head.json.gz
+          path: /tmp
+      - name: 'Check for removed HTML IDs'
+        run: >-
+          python Doc/tools/check-html-ids.py check
+          /tmp/html-ids-base.json.gz /tmp/html-ids-head.json.gz
+        # XXX: When an exclude file is added, update this to use it:
+        # --exclude-file Doc/tools/removed-ids.txt

.github/workflows/reusable-docs.yml

@@ -76,8 +76,10 @@ jobs:
           --fail-if-improved \
           --fail-if-new-news-nit
     - name: 'Collect HTML IDs'
+      if: github.event_name == 'pull_request'
       run: python Doc/tools/check-html-ids.py collect Doc/build/html -o Doc/build/html-ids-head.json.gz
     - name: 'Upload HTML IDs'
+      if: github.event_name == 'pull_request'
       uses: actions/upload-artifact@v7
       with:
         name: html-ids-head
@@ -87,37 +89,8 @@ jobs:
   check-html-ids:
     name: 'Check for removed HTML IDs'
     needs: build-doc
-    runs-on: ubuntu-latest
-    timeout-minutes: 30
-    steps:
-    - name: 'Check out base commit'
-      uses: actions/checkout@v6
-      with:
-        persist-credentials: false
-        ref: ${{ github.event.pull_request.base.sha || github.event.before }}
-    - name: 'Set up Python'
-      uses: actions/setup-python@v6
-      with:
-        python-version: '3'
-        cache: 'pip'
-        cache-dependency-path: 'Doc/requirements.txt'
-    - name: 'Install build dependencies'
-      run: make -C Doc/ venv
-    - name: 'Build HTML documentation'
-      run: make -C Doc/ SPHINXOPTS="--quiet" html
-    - name: 'Collect HTML IDs'
-      run: python Doc/tools/check-html-ids.py collect Doc/build/html -o /tmp/html-ids-base.json.gz
-    - name: 'Download PR base HTML IDs'
-      uses: actions/download-artifact@v8
-      with:
-        name: html-ids-head.json.gz
-        path: /tmp
-    - name: 'Check for removed HTML IDs'
-      run: >-
-        python Doc/tools/check-html-ids.py check
-        /tmp/html-ids-base.json.gz /tmp/html-ids-head.json.gz
-      # XXX: When an exclude file is added, update this to use it:
-      # --exclude-file Doc/tools/removed-ids.txt
+    if: github.event_name == 'pull_request'
+    uses: ./.github/workflows/reusable-check-html-ids.yml
 
   # Run "doctest" on HEAD as new syntax doesn't exist in the latest stable release
   doctest: