[3.14] gh-150178: Fix refcount leaks in hamt allocation failure paths (GH-150179) (#150302)

miss-islington · lpyu001 · web-flow · commit 5676bfcf8595 · 2026-05-24T07:42:21.000Z
gh-150178: Fix refcount leaks in hamt allocation failure paths (GH-150179) (cherry picked from commit 32823af) Co-authored-by: pengyu lee <lipengyu@kylinos.cn>
diff --git a/Python/hamt.c b/Python/hamt.c
@@ -701,6 +701,7 @@ hamt_node_bitmap_assoc(PyHamtNode_Bitmap *self,
 
             PyHamtNode_Bitmap *ret = hamt_node_bitmap_clone(self);
             if (ret == NULL) {
+                Py_DECREF(sub_node);
                 return NULL;
             }
             Py_SETREF(ret->b_array[val_idx], (PyObject*)sub_node);
@@ -993,6 +994,7 @@ hamt_node_bitmap_without(PyHamtNode_Bitmap *self,
 
                 PyHamtNode_Bitmap *clone = hamt_node_bitmap_clone(self);
                 if (clone == NULL) {
+                    Py_DECREF(sub_node);
                     return W_ERROR;
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -701,6 +701,7 @@ hamt_node_bitmap_assoc(PyHamtNode_Bitmap *self,`
`701`	`701`
`702`	`702`	`PyHamtNode_Bitmap *ret = hamt_node_bitmap_clone(self);`
`703`	`703`	`if (ret == NULL) {`
	`704`	`+ Py_DECREF(sub_node);`
`704`	`705`	`return NULL;`
`705`	`706`	`}`
`706`	`707`	`Py_SETREF(ret->b_array[val_idx], (PyObject*)sub_node);`
`@@ -993,6 +994,7 @@ hamt_node_bitmap_without(PyHamtNode_Bitmap *self,`
`993`	`994`
`994`	`995`	`PyHamtNode_Bitmap *clone = hamt_node_bitmap_clone(self);`
`995`	`996`	`if (clone == NULL) {`
	`997`	`+ Py_DECREF(sub_node);`
`996`	`998`	`return W_ERROR;`
`997`	`999`	`}`
`998`	`1000`