[3.15] gh-150178: Fix refcount leaks in hamt allocation failure paths (GH-150179) (#150303)

miss-islington · lpyu001 · web-flow · commit 6b17d1a783d3 · 2026-05-23T19:27:27.000Z
gh-150178: Fix refcount leaks in hamt allocation failure paths (GH-150179) (cherry picked from commit 32823af) Co-authored-by: pengyu lee <lipengyu@kylinos.cn>
diff --git a/Python/hamt.c b/Python/hamt.c
@@ -702,6 +702,7 @@ hamt_node_bitmap_assoc(PyHamtNode_Bitmap *self,
 
             PyHamtNode_Bitmap *ret = hamt_node_bitmap_clone(self);
             if (ret == NULL) {
+                Py_DECREF(sub_node);
                 return NULL;
             }
             Py_SETREF(ret->b_array[val_idx], (PyObject*)sub_node);
@@ -994,6 +995,7 @@ hamt_node_bitmap_without(PyHamtNode_Bitmap *self,
 
                 PyHamtNode_Bitmap *clone = hamt_node_bitmap_clone(self);
                 if (clone == NULL) {
+                    Py_DECREF(sub_node);
                     return W_ERROR;
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -702,6 +702,7 @@ hamt_node_bitmap_assoc(PyHamtNode_Bitmap *self,`
`702`	`702`
`703`	`703`	`PyHamtNode_Bitmap *ret = hamt_node_bitmap_clone(self);`
`704`	`704`	`if (ret == NULL) {`
	`705`	`+ Py_DECREF(sub_node);`
`705`	`706`	`return NULL;`
`706`	`707`	`}`
`707`	`708`	`Py_SETREF(ret->b_array[val_idx], (PyObject*)sub_node);`
`@@ -994,6 +995,7 @@ hamt_node_bitmap_without(PyHamtNode_Bitmap *self,`
`994`	`995`
`995`	`996`	`PyHamtNode_Bitmap *clone = hamt_node_bitmap_clone(self);`
`996`	`997`	`if (clone == NULL) {`
	`998`	`+ Py_DECREF(sub_node);`
`997`	`999`	`return W_ERROR;`
`998`	`1000`	`}`
`999`	`1001`