Skip to content

Commit a05c48f

Browse files
skirpichevpicnixz
andauthored
Apply suggestions from code review
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
1 parent de60f6b commit a05c48f

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

Lib/test/test_math_integer.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -279,10 +279,10 @@ def test_isqrt_rem(self):
279279
isqrt_rem(MyIndexable(-3))
280280

281281
# Non-integer-like things
282-
bad_values = [
283-
3.5, "a string", Decimal("3.5"), 3.5j,
284-
100.0, -4.0,
285-
]
282+
bad_values = [
283+
3.5, "3.5", Decimal("3.5"), 3.5j,
284+
100.0, -4.0,
285+
]
286286
for value in bad_values:
287287
with self.subTest(value=value):
288288
with self.assertRaises(TypeError):

Modules/mathintegermodule.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,6 @@ math_integer_isqrt_rem(PyObject *module, PyObject *n)
541541
Py_XDECREF(root);
542542
Py_XDECREF(rem);
543543
return res;
544-
return NULL;
545544
}
546545

547546

0 commit comments

Comments
 (0)