gh-150315: increase test coverage for asyncio._FlowControlMixin.set_write_buffer_limits#150317
Open
azibom wants to merge 1 commit into
Open
gh-150315: increase test coverage for asyncio._FlowControlMixin.set_write_buffer_limits#150317azibom wants to merge 1 commit into
asyncio._FlowControlMixin.set_write_buffer_limits#150317azibom wants to merge 1 commit into
Conversation
azibom
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
picnixz
reviewed
May 23, 2026
Comment on lines
+125
to
+127
| transport.get_write_buffer_limits(), | ||
| (50, 200) | ||
| ) |
Member
There was a problem hiding this comment.
I think those lines can be collapsed. It's taking too much vertical space (or are we already exceeding 80 chars in width?)
picnixz
changed the title
asyncio._FlowControlMixin.set_write_buffer_limits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test coverage for computed write buffer limit behavior in
asyncio._FlowControlMixin.
The new tests verify:
highcomputed fromlowlowcomputed fromhighThese behaviors are implemented in
_set_write_buffer_limits()but were not explicitly covered by tests.
Tests help protect against future regressions in flow control
buffer calculations.
Closes gh-150315.