Address feedback

Author: JukkaL

mypyc/irbuild/expression.py

@@ -368,11 +368,8 @@ def transform_call_expr(builder: IRBuilder, expr: CallExpr) -> Value:
             if len(expr.args) == 0 or (len(expr.args) == 1 and expr.arg_kinds == [ARG_NAMED]):
                 # vec[T]() or vec[T](capacity=N)
                 return vec_create(builder.builder, vec_type, 0, expr.line, capacity=capacity)
-            elif (
-                len(expr.args) == 1
-                and expr.arg_kinds == [ARG_POS]
-                or len(expr.args) == 2
-                and expr.arg_kinds == [ARG_POS, ARG_NAMED]
+            elif (len(expr.args) == 1 and expr.arg_kinds == [ARG_POS]) or (
+                len(expr.args) == 2 and expr.arg_kinds == [ARG_POS, ARG_NAMED]
             ):
                 # vec[T](items) or vec[T](items, capacity=N)
                 return translate_vec_create_from_iterable(

mypyc/lib-rt/vecs/vec_nested.c

@@ -569,7 +569,7 @@ PyTypeObject VecNestedType = {
 };
 
 PyObject *VecNested_FromIterable(size_t item_type, size_t depth, PyObject *iterable, int64_t cap) {
-    VecNested v = vec_alloc(cap > 0 ? cap : 0, item_type, depth);
+    VecNested v = vec_alloc(cap, item_type, depth);
     if (VEC_IS_ERROR(v))
         return NULL;
     if (cap > 0) {

mypyc/lib-rt/vecs/vec_t.c

@@ -562,7 +562,7 @@ PyTypeObject VecTType = {
 };
 
 PyObject *VecT_FromIterable(size_t item_type, PyObject *iterable, int64_t cap) {
-    VecT v = vec_alloc(cap > 0 ? cap : 0, item_type);
+    VecT v = vec_alloc(cap, item_type);
     if (VEC_IS_ERROR(v))
         return NULL;
     if (cap > 0) {

mypyc/lib-rt/vecs/vec_template.c

@@ -101,7 +101,7 @@ VEC FUNC(New)(Py_ssize_t size, Py_ssize_t cap) {
 }
 
 PyObject *FUNC(FromIterable)(PyObject *iterable, int64_t cap) {
-    VEC v = vec_alloc(cap > 0 ? cap : 0);
+    VEC v = vec_alloc(cap);
     if (VEC_IS_ERROR(v))
         return NULL;
     if (cap > 0) {

mypyc/test-data/run-vecs-t-interp.test

@@ -587,7 +587,8 @@ def test_cap_reallocation() -> None:
     old = v
     v = append(v, 'c')
     old = append(old, 'Q')
-    assert v[0] == 'a'
+    assert v[2] == 'c'
+    assert old[2] == 'Q'
 
     # Old alias retains original items after reallocation
     v = vec[str](['a', 'b', 'c'], capacity=3)