From 7f53170ac74c2182141a9d3a5ad9a5ac3d91e759 Mon Sep 17 00:00:00 2001 From: Hansong Zhang Date: Fri, 15 May 2026 15:07:22 -0700 Subject: [PATCH] Fix GenerationConfig initialization in qnn_multimodal_runner Summary: ...changes. - Replace fragile positional initialization with explicit field assignments - Improves code clarity by making field names explicit - Makes the code robust to future changes in GenerationConfig struct Differential Revision: D105377713 --- .../oss_scripts/llama/qnn_multimodal_runner.cpp | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/examples/qualcomm/oss_scripts/llama/qnn_multimodal_runner.cpp b/examples/qualcomm/oss_scripts/llama/qnn_multimodal_runner.cpp index 1a7da5d62d3..29b6b9d7ddc 100644 --- a/examples/qualcomm/oss_scripts/llama/qnn_multimodal_runner.cpp +++ b/examples/qualcomm/oss_scripts/llama/qnn_multimodal_runner.cpp @@ -177,14 +177,15 @@ void start_multimodal_runner( } }; executorch::extension::llm::GenerationConfig config{ - true, - false, - -1, - false, - FLAGS_seq_len, - static_cast(FLAGS_temperature), - 0, - 0}; + .echo = true, + .ignore_eos = false, + .max_new_tokens = -1, + .warming = false, + .seq_len = FLAGS_seq_len, + .temperature = static_cast(FLAGS_temperature), + .num_bos = 0, + .num_eos = 0, + }; // 1. [Multimodal] Get raw files from input_list.txt std::vector audio_raw_files;