Skip to content

[Refactor] Rename "DAG" to "CircuitSeq" #60

@xumingkuan

Description

@xumingkuan

The name DAG is a bit confusing in that the term "DAG" is not the best name to describe it. It is actually the "Sequence Representation" in our paper (https://arxiv.org/pdf/2204.09033.pdf, page 4, section 3.1).

I am considering renaming it to CircuitSeq to avoid confusion. Here is the complete renaming plan:

  • DAG -> CircuitSeq
  • DAGNode -> CircuitWire
  • DAGHyperEdge -> CircuitGate (I am not sure if this is clear enough that this is a gate in a circuit and easily distinguishable with the abstract Gate type)
  • DAG::nodes -> CircuitSeq::wires
  • DAG::edges -> CircuitSeq::gates
  • DAGNode::input_edges -> CircuitWire::input_gates
  • DAGNode::output_edges -> CircuitWire::output_gates
  • DAGHyperEdge::input_nodes -> CircuitGate::input_wires
  • DAGHyperEdge::output_nodes -> CircuitGate::output_wires
  • Graph::to_dag -> Graph::to_circuit_sequence

Do you think the new names are clear? Any suggestions are welcome.


Edit after merging #61: the class name is renamed, but there are a lot of variable names still being dag. Help wanted for renaming these to seq :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions