From 85e83bad3a5a5157c479527f2bd3296f833f13fc Mon Sep 17 00:00:00 2001 From: mhucka Date: Sun, 12 Apr 2026 04:25:50 +0000 Subject: [PATCH 1/2] Micro-optimization: replace list lookup with set membership Use a set for `GATE_PARAMS` to achieve O(1) lookups. --- qsimcirq/qsim_circuit.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qsimcirq/qsim_circuit.py b/qsimcirq/qsim_circuit.py index a5b4ae277..0b94436a7 100644 --- a/qsimcirq/qsim_circuit.py +++ b/qsimcirq/qsim_circuit.py @@ -20,7 +20,7 @@ from . import qsim # List of parameter names that appear in valid Cirq protos. -GATE_PARAMS = [ +GATE_PARAMS = { "exponent", "phase_exponent", "global_shift", @@ -29,7 +29,7 @@ "axis_phase_exponent", "phi", "theta", -] +} def _translate_ControlledGate(gate: cirq.ControlledGate): From 213f716783ee3d571d3c8fb50851507c335f158c Mon Sep 17 00:00:00 2001 From: Michael Hucka Date: Sat, 11 Apr 2026 22:07:29 -0700 Subject: [PATCH 2/2] Correct comment --- qsimcirq/qsim_circuit.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qsimcirq/qsim_circuit.py b/qsimcirq/qsim_circuit.py index 0b94436a7..a78c5cae3 100644 --- a/qsimcirq/qsim_circuit.py +++ b/qsimcirq/qsim_circuit.py @@ -19,7 +19,7 @@ from . import qsim -# List of parameter names that appear in valid Cirq protos. +# Set of parameter names that appear in valid Cirq protos. GATE_PARAMS = { "exponent", "phase_exponent",