Accept true/false for --fix-block-reorgs (DX-5694)

The flag took a raw 0/1 integer. It now parses as a bool via clap's
BoolishValueParser, so the documented form is true/false while 0/1
(and yes/no) keep working. The value still maps to the integer the
streams API expects.

Author: johnpmitsch

src/commands/stream/actions.rs

@@ -92,7 +92,8 @@ fn build_create_params(a: CreateArgs) -> Result<CreateStreamParams, CliError> {
         status: a.status.map(Into::into),
         notification_email: a.notification_email,
         charge_min_cap: None,
-        fix_block_reorgs: a.fix_block_reorgs,
+        // The API models this as 0/1.
+        fix_block_reorgs: a.fix_block_reorgs.map(i32::from),
         elastic_batch_enabled: a.elastic_batch_enabled.unwrap_or(false),
         extra_destinations: None,
     })

src/commands/stream/mod.rs

@@ -131,9 +131,9 @@ pub struct CreateArgs {
     /// dataset_batch_size (defaults to 1).
     #[arg(long)]
     pub batch_size: Option<i64>,
-    /// fix_block_reorgs (0/1).
-    #[arg(long)]
-    pub fix_block_reorgs: Option<i32>,
+    /// Fix block reorgs (true/false).
+    #[arg(long, value_parser = clap::builder::BoolishValueParser::new())]
+    pub fix_block_reorgs: Option<bool>,
     /// elastic_batch_enabled.
     #[arg(long)]
     pub elastic_batch_enabled: Option<bool>,

tests/streams.rs

@@ -81,6 +81,46 @@ async fn create_stream_webhook_destination() {
     assert_eq!(out.exit_code, 0, "stderr={}", out.stderr);
 }
 
+#[tokio::test]
+async fn create_stream_fix_block_reorgs_accepts_bool_and_sends_int() {
+    let server = MockServer::start().await;
+    Mock::given(method("POST"))
+        .and(path("/streams/rest/v1/streams"))
+        .and(body_partial_json(json!({ "fix_block_reorgs": 1 })))
+        .respond_with(ResponseTemplate::new(200).set_body_json(stream_payload("s-new")))
+        .expect(2)
+        .mount(&server)
+        .await;
+    // `true` is the documented form; bare `1` keeps working via the boolish parser.
+    for value in ["true", "1"] {
+        let out = run_qn(
+            &server.uri(),
+            &[
+                "stream",
+                "create",
+                "--name",
+                "s1",
+                "--network",
+                "ethereum-mainnet",
+                "--dataset",
+                "block",
+                "--start",
+                "100",
+                "--end",
+                "-1",
+                "--region",
+                "usa-east",
+                "--webhook",
+                "https://hook.example/x",
+                "--fix-block-reorgs",
+                value,
+            ],
+        )
+        .await;
+        assert_eq!(out.exit_code, 0, "value={value} stderr={}", out.stderr);
+    }
+}
+
 #[tokio::test]
 async fn create_stream_webhook_destination_with_gzip() {
     let server = MockServer::start().await;