Address vault Strategy PDA by index instead of manager key

The Strategy PDA was derived from seeds "strategy" + manager pubkey. Switch
to a simpler caller-chosen index, e.g. "strategy" + 0, so strategies are
addressed by a counter rather than the manager's key.

- Add `index: u64` to the Strategy account, set at creation and used to
  re-derive the PDA wherever it signs for the vaults and share mint.
- `initialize_strategy` now takes an `index` argument used in the PDA seeds.
- deposit, invest, rebalance, collect_fees, withdraw, add_asset re-derive the
  strategy PDA from the stored index; the manager is still recorded as a field
  and keeps its manager-only powers, it is just no longer part of the address.
- Update tests, README, and the video script to match.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RajngzX57RGaQx5sKPbysZ

Author: claude

finance/vault-strategy/VIDEO_SCRIPT.md

@@ -29,7 +29,7 @@ Custody is the whole game, so let us name the boxes before we move money.
 
 First, the word vault, because it gets overloaded. By the common standard a vault holds a single asset: you put one kind of token in, you get shares out. A managed mix of several assets is not one vault; it lives in several vaults, one per asset, and is usually called a basket or a fund. Symmetry calls its multi-asset products baskets. We will keep it simple: a vault is one single-asset token account, and the strategy is the whole construct that owns them. So vault strategy reads literally, a strategy built from vaults.
 
-The center of everything is the `Strategy` account, whose address is a PDA derived from the seeds `"strategy"` plus Maria's public key. A PDA is an address with no private key: it is found deliberately off the signing curve, so no key can sign for it and only the program can, by supplying the seeds. The strategy PDA is the authority over the USDC vault, every asset vault, and the share mint. Each vault is an associated token account owned by the strategy PDA and holds exactly one asset. The share mint's address is also a PDA, seeds `"share_mint"` plus the strategy address, so it is deterministic, one share mint per strategy, with the strategy PDA as its mint authority.
+The center of everything is the `Strategy` account, whose address is a PDA derived from the seeds `"strategy"` plus an index: zero for the first strategy, one for the next, and so on. A PDA is an address with no private key: it is found deliberately off the signing curve, so no key can sign for it and only the program can, by supplying the seeds. The strategy PDA is the authority over the USDC vault, every asset vault, and the share mint. Each vault is an associated token account owned by the strategy PDA and holds exactly one asset. The share mint's address is also a PDA, seeds `"share_mint"` plus the strategy address, so it is deterministic, one share mint per strategy, with the strategy PDA as its mint authority.
 
 The asset set is not fixed. Each asset the strategy holds gets its own small account, an `AssetConfig`, whose address is a PDA seeded by the strategy and an index: zero, one, two, and so on. That indexing matters later: the assets are exactly the range zero up to the count, so any handler that values the whole strategy can re-derive every one and refuse to run if a single asset account is missing.
 
@@ -39,7 +39,7 @@ ON SCREEN:
 
 ```
 Registry            [off curve - PDA, seeds: "registry" + authority]   owner = curator, not a manager
-Strategy            [off curve - PDA, seeds: "strategy" + manager]
+Strategy            [off curve - PDA, seeds: "strategy" + index]   manager stored as a field, not a seed
     authority over: vault_usdc, every asset vault, share_mint
 share_mint          [off curve - PDA, seeds: "share_mint" + strategy]   authority = Strategy PDA
 AssetConfig #i      [off curve - PDA, seeds: "asset" + strategy + index]  one per asset
@@ -72,15 +72,15 @@ Fee generated: none
 
 NARRATION:
 
-Maria is our portfolio manager, and she wants to run the basket and earn the fee. She calls `initialize_strategy`, binding her strategy to Victor's registry. She sets two numbers and no assets yet: a fee of one hundred basis points, which is one percent a year, and a maximum slippage of one hundred basis points, which we will use when she trades. Both are capped in code, the fee at ten percent and the slippage tolerance at ten percent, and both are fixed here at creation with no setter to change them later.
+Maria is our portfolio manager, and she wants to run the basket and earn the fee. She calls `initialize_strategy`, picking index zero, which fixes her strategy's address at the seeds `"strategy"` plus zero, and binding it to Victor's registry. Her own key is still recorded on the strategy as the manager, the account that holds her management powers; it is just no longer part of the address. She sets two numbers and no assets yet: a fee of one hundred basis points, which is one percent a year, and a maximum slippage of one hundred basis points, which we will use when she trades. Both are capped in code, the fee at ten percent and the slippage tolerance at ten percent, and both are fixed here at creation with no setter to change them later.
 
 The fee cap exists because the fee is paid by minting new shares to the manager; an uncapped fee would let a manager dilute depositors to nothing by configuration alone.
 
 ON SCREEN:
 
 ```
-ADDED - Strategy            [off curve - PDA]
-    manager: Maria   registry: Victor's registry
+ADDED - Strategy            [off curve - PDA, seeds: "strategy" + 0]
+    index: 0   manager: Maria   registry: Victor's registry
     fee_bps: 100   max_slippage_bps: 100   total_shares: 0
     asset_count: 0   total_weight_bps: 0   last_fee_accrual_timestamp: now
 

finance/vault-strategy/anchor/README.md

@@ -78,7 +78,7 @@ An [in-kind distribution](https://www.investopedia.com/terms/i/in-kind.asp) retu
 
 ### Step 2 - Maria initializes the strategy
 
-`initialize_strategy(fee_bps=100, max_slippage_bps=100, swap_router)` creates the `Strategy` PDA (`["strategy", maria]`), the share mint, and the USDC vault, binding the strategy to Victor's registry. No assets yet.
+`initialize_strategy(index=0, fee_bps=100, max_slippage_bps=100, swap_router)` creates the `Strategy` PDA (`["strategy", 0]`), the share mint, and the USDC vault, binding the strategy to Victor's registry. The strategy is addressed by a caller-chosen index (`"strategy" + 0`, `"strategy" + 1`, …) rather than the manager's key. No assets yet.
 
 ### Step 3 - Maria adds assets
 

finance/vault-strategy/anchor/programs/vault-strategy/src/instructions/add_asset.rs

@@ -16,7 +16,7 @@ pub struct AddAssetAccountConstraints<'info> {
         mut,
         has_one = manager,
         has_one = registry @ VaultError::InvalidRegistry,
-        seeds = [b"strategy", strategy.manager.as_ref()],
+        seeds = [b"strategy", strategy.index.to_le_bytes().as_ref()],
         bump = strategy.bump
     )]
     pub strategy: Box<Account<'info, Strategy>>,

finance/vault-strategy/anchor/programs/vault-strategy/src/instructions/collect_fees.rs

@@ -17,7 +17,7 @@ pub struct CollectFeesAccountConstraints<'info> {
     #[account(
         mut,
         has_one = manager,
-        seeds = [b"strategy", strategy.manager.as_ref()],
+        seeds = [b"strategy", strategy.index.to_le_bytes().as_ref()],
         bump = strategy.bump
     )]
     pub strategy: Account<'info, Strategy>,
@@ -57,7 +57,7 @@ pub fn handle_collect_fees(context: Context<CollectFeesAccountConstraints>) -> R
     let elapsed_seconds = (current_ts - last_ts) as u64;
     let total_shares = context.accounts.strategy.total_shares;
     let fee_bps = context.accounts.strategy.fee_bps;
-    let manager_key = context.accounts.strategy.manager;
+    let strategy_index = context.accounts.strategy.index;
     let strategy_bump = context.accounts.strategy.bump;
 
     // fee_shares = total_shares * fee_bps * elapsed / (10_000 * SECONDS_PER_YEAR)
@@ -86,7 +86,8 @@ pub fn handle_collect_fees(context: Context<CollectFeesAccountConstraints>) -> R
         .ok_or(VaultError::MathOverflow)?;
 
     // Mint fee shares to manager - strategy PDA signs
-    let signer_seeds: &[&[&[u8]]] = &[&[b"strategy", manager_key.as_ref(), &[strategy_bump]]];
+    let index_bytes = strategy_index.to_le_bytes();
+    let signer_seeds: &[&[&[u8]]] = &[&[b"strategy", index_bytes.as_ref(), &[strategy_bump]]];
 
     let mint_accounts = MintTo {
         mint: context.accounts.share_mint.to_account_info(),

finance/vault-strategy/anchor/programs/vault-strategy/src/instructions/deposit.rs

@@ -18,7 +18,7 @@ pub struct DepositAccountConstraints<'info> {
     #[account(
         mut,
         has_one = usdc_mint @ VaultError::InvalidUsdcMint,
-        seeds = [b"strategy", strategy.manager.as_ref()],
+        seeds = [b"strategy", strategy.index.to_le_bytes().as_ref()],
         bump = strategy.bump
     )]
     pub strategy: Box<Account<'info, Strategy>>,
@@ -74,7 +74,7 @@ pub fn handle_deposit<'info>(
     let vault_usdc_amount = context.accounts.vault_usdc.amount;
     let total_shares = context.accounts.strategy.total_shares;
     let usdc_decimals = context.accounts.usdc_mint.decimals;
-    let manager_key = context.accounts.strategy.manager;
+    let strategy_index = context.accounts.strategy.index;
     let strategy_bump = context.accounts.strategy.bump;
     let strategy_key = context.accounts.strategy.key();
     let asset_count = context.accounts.strategy.asset_count as usize;
@@ -146,7 +146,8 @@ pub fn handle_deposit<'info>(
     let cpi_ctx = CpiContext::new(context.accounts.token_program.key(), transfer_accounts);
     transfer_checked(cpi_ctx, usdc_amount, usdc_decimals)?;
 
-    let signer_seeds: &[&[&[u8]]] = &[&[b"strategy", manager_key.as_ref(), &[strategy_bump]]];
+    let index_bytes = strategy_index.to_le_bytes();
+    let signer_seeds: &[&[&[u8]]] = &[&[b"strategy", index_bytes.as_ref(), &[strategy_bump]]];
     let mint_accounts = MintTo {
         mint: context.accounts.share_mint.to_account_info(),
         to: context.accounts.depositor_share_account.to_account_info(),

finance/vault-strategy/anchor/programs/vault-strategy/src/instructions/initialize_strategy.rs

@@ -20,6 +20,7 @@ pub const MAX_FEE_BPS: u16 = 1_000;
 pub const MAX_SLIPPAGE_BPS: u16 = 1_000;
 
 #[derive(Accounts)]
+#[instruction(index: u64)]
 pub struct InitializeStrategyAccountConstraints<'info> {
     #[account(mut)]
     pub manager: Signer<'info>,
@@ -33,7 +34,7 @@ pub struct InitializeStrategyAccountConstraints<'info> {
         init,
         payer = manager,
         space = Strategy::DISCRIMINATOR.len() + Strategy::INIT_SPACE,
-        seeds = [b"strategy", manager.key().as_ref()],
+        seeds = [b"strategy", index.to_le_bytes().as_ref()],
         bump
     )]
     pub strategy: Box<Account<'info, Strategy>>,
@@ -67,6 +68,7 @@ pub struct InitializeStrategyAccountConstraints<'info> {
 
 pub fn handle_initialize_strategy(
     context: Context<InitializeStrategyAccountConstraints>,
+    index: u64,
     fee_bps: u16,
     max_slippage_bps: u16,
     swap_router: Pubkey,
@@ -80,6 +82,7 @@ pub fn handle_initialize_strategy(
     let clock = Clock::get()?;
 
     context.accounts.strategy.set_inner(Strategy {
+        index,
         manager: context.accounts.manager.key(),
         registry: context.accounts.registry.key(),
         share_mint: context.accounts.share_mint.key(),

finance/vault-strategy/anchor/programs/vault-strategy/src/instructions/invest.rs

@@ -20,7 +20,7 @@ pub struct InvestAccountConstraints<'info> {
         mut,
         has_one = manager,
         has_one = usdc_mint @ VaultError::InvalidUsdcMint,
-        seeds = [b"strategy", strategy.manager.as_ref()],
+        seeds = [b"strategy", strategy.index.to_le_bytes().as_ref()],
         bump = strategy.bump
     )]
     pub strategy: Box<Account<'info, Strategy>>,
@@ -86,7 +86,7 @@ pub struct InvestAccountConstraints<'info> {
 
 pub fn handle_invest(context: Context<InvestAccountConstraints>, usdc_amount: u64) -> Result<()> {
     let strategy = &context.accounts.strategy;
-    let manager_key = strategy.manager;
+    let strategy_index = strategy.index;
     let strategy_bump = strategy.bump;
     let max_slippage_bps = strategy.max_slippage_bps;
 
@@ -113,7 +113,8 @@ pub fn handle_invest(context: Context<InvestAccountConstraints>, usdc_amount: u6
         .try_into()
         .map_err(|_| VaultError::MathOverflow)?;
 
-    let signer_seeds: &[&[&[u8]]] = &[&[b"strategy", manager_key.as_ref(), &[strategy_bump]]];
+    let index_bytes = strategy_index.to_le_bytes();
+    let signer_seeds: &[&[&[u8]]] = &[&[b"strategy", index_bytes.as_ref(), &[strategy_bump]]];
 
     let cpi_accounts = RouterSwapAccounts {
         caller: context.accounts.strategy.to_account_info(),

finance/vault-strategy/anchor/programs/vault-strategy/src/instructions/rebalance.rs

@@ -20,7 +20,7 @@ pub struct RebalanceAccountConstraints<'info> {
         mut,
         has_one = manager,
         has_one = usdc_mint @ VaultError::InvalidUsdcMint,
-        seeds = [b"strategy", strategy.manager.as_ref()],
+        seeds = [b"strategy", strategy.index.to_le_bytes().as_ref()],
         bump = strategy.bump
     )]
     pub strategy: Box<Account<'info, Strategy>>,
@@ -116,7 +116,7 @@ pub fn handle_rebalance(
     );
 
     let strategy = &context.accounts.strategy;
-    let manager_key = strategy.manager;
+    let strategy_index = strategy.index;
     let strategy_bump = strategy.bump;
     let slip = (10_000 - strategy.max_slippage_bps) as u128;
 
@@ -160,7 +160,8 @@ pub fn handle_rebalance(
         .try_into()
         .map_err(|_| VaultError::MathOverflow)?;
 
-    let signer_seeds: &[&[&[u8]]] = &[&[b"strategy", manager_key.as_ref(), &[strategy_bump]]];
+    let index_bytes = strategy_index.to_le_bytes();
+    let signer_seeds: &[&[&[u8]]] = &[&[b"strategy", index_bytes.as_ref(), &[strategy_bump]]];
 
     // Step 1: sell basket token -> USDC
     let sell_cpi_accounts = RouterSellAccounts {

finance/vault-strategy/anchor/programs/vault-strategy/src/instructions/withdraw.rs

@@ -18,7 +18,7 @@ pub struct WithdrawAccountConstraints<'info> {
     #[account(
         mut,
         has_one = usdc_mint @ VaultError::InvalidUsdcMint,
-        seeds = [b"strategy", strategy.manager.as_ref()],
+        seeds = [b"strategy", strategy.index.to_le_bytes().as_ref()],
         bump = strategy.bump
     )]
     pub strategy: Box<Account<'info, Strategy>>,
@@ -77,7 +77,7 @@ pub fn handle_withdraw<'info>(
 
     let vault_usdc_amount = context.accounts.vault_usdc.amount;
     let usdc_decimals = context.accounts.usdc_mint.decimals;
-    let manager_key = context.accounts.strategy.manager;
+    let strategy_index = context.accounts.strategy.index;
     let strategy_bump = context.accounts.strategy.bump;
     let strategy_key = context.accounts.strategy.key();
     let user_key = context.accounts.user.key();
@@ -104,7 +104,8 @@ pub fn handle_withdraw<'info>(
         .checked_sub(shares_to_burn)
         .ok_or(VaultError::MathOverflow)?;
 
-    let signer_seeds: &[&[&[u8]]] = &[&[b"strategy", manager_key.as_ref(), &[strategy_bump]]];
+    let index_bytes = strategy_index.to_le_bytes();
+    let signer_seeds: &[&[&[u8]]] = &[&[b"strategy", index_bytes.as_ref(), &[strategy_bump]]];
 
     // Hoist owned account-info handles for every CPI up front, so the asset loop
     // can borrow remaining_accounts without also re-borrowing `context.accounts`

finance/vault-strategy/anchor/programs/vault-strategy/src/lib.rs

@@ -29,14 +29,18 @@ pub mod vault_strategy {
         instructions::whitelist_asset::handle_whitelist_asset(context, price_feed)
     }
 
+    /// Open a strategy at a caller-chosen index, e.g. index 0 derives the PDA
+    /// from seeds `"strategy" + 0`. Manager pays and becomes the strategy's manager.
     pub fn initialize_strategy(
         context: Context<InitializeStrategyAccountConstraints>,
+        index: u64,
         fee_bps: u16,
         max_slippage_bps: u16,
         swap_router: Pubkey,
     ) -> Result<()> {
         instructions::initialize_strategy::handle_initialize_strategy(
             context,
+            index,
             fee_bps,
             max_slippage_bps,
             swap_router,