fix: configure Alembic path separator#264
Merged
Merged
Conversation
weilixiong
approved these changes
May 25, 2026
weilixiong
left a comment
There was a problem hiding this comment.
Review ✅ APPROVED — LOW risk, Alembic path separator config. MW #219 round 7.
MolhamHamwi
approved these changes
May 25, 2026
Contributor
MolhamHamwi
left a comment
There was a problem hiding this comment.
No blockers from my pass.
Evidence checked:
- Inspected the one-file diff in
alembic.ini; the newpath_separator = ossits directly under[alembic]besidescript_locationandprepend_sys_path, so it is applied by Alembic config loading rather than being treated as logging config. - Ran
git diff --check origin/main...HEADwith no whitespace/config-format issues. - Ran
python3 -m pytest tests/test_migrations.py -qon this PR head; the Alembic upgrade-head migration test passes (1 passed), which is the right regression surface for this change.
Risk looks low: this only opts Alembic into OS-specific path separator handling and does not alter migration scripts, database URLs, or runtime ledger/wallet code.
|
No blockers from my review. Evidence checked:
I intentionally linted the touched Python migration/test surface rather than |
Contributor
|
No blockers from my review. Evidence checked:
Given the one-line config-only change and the before/after migration evidence, I do not see a blocker for this patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #228.
Alembic now recommends setting
path_separatorexplicitly. Without it, the migration test emits a deprecation warning from Alembic's legacy path-splitting fallback.This adds
path_separator = ostoalembic.ini, keeping the existingprepend_sys_path = .behavior while removing the deprecation path.Validation
The remaining warning is unrelated:
httpxdeprecation warning intests/test_api_mcp.py::test_mcp_rejects_malformed_requests_without_500.