Skip to content

Wrong function is used for calculating dense score #40

@dangkhoasdc

Description

@dangkhoasdc

In the doc of dense_scores, it is mentioned that: torch.mean is dedicated to training

func
Either torch.sum or torch.mean. torch.mean is dedicated to training and
torch.sum is dedicated to inference.

However, in your training function of SparseEmb, you use torch.sum instead. So which one is preferable for training? I guess it should be torch.mean?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions