`image.album` can be null if image file previously deleted

[Libarch]

Hi, thanks for this excellent module which has already saved me loads of time.

Opening my Digikam database (digikam4.db) with sqliteman, I can see that the images table includes previously-deleted image files, with status set to 3 and album to null. These rows are included in lists returned by dk.images.all(). So for example, executing this code when some image files tagged with My tag have previously been updated will throw an AttributeError when the iteration reaches the first 'deleted' image:

dk = Digikam('digikamrc')
my_images = dk.tags['My tag'].images.all()
for i in my_images:
path_to_image = i.abspath
throws

Traceback (most recent call last):
File "<...>/test_ddb.py", line 17, in
path_to_image = i.abspath
^^^^^^^^^
File "<...>/.venv/lib64/python3.11/site-packages/digikamdb/images.py", line 444, in abspath
self.album.abspath,
^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'abspath'

Should there be something like an include-deleted (default = False) arg in the images.all() method to filter out these rows? Or specifically in the abspath call, a test for a null album attribute? In the meantime an easy workaround is to use

my_images = [i for i in dk.tags['My tag'].images if i.album]

instead of images.all()

Hope this makes sense

[rcw-2]

Thank you for the hint. Returning None as abspath for images without an album seems logical, so it will be in the next version.

[rcw-2]

Furthermore, some way to ignore deleted images seems a good idea. Maybe an option to the Digikam constructor affecting all image queries.

The images property returns a SQLAlchemy Query (it is implemented as a dynamic relationship), so I think changing the all method is too complicated. Adding a default filter may be possible.

Would this be helpful to you (or others)?

[Libarch]

Furthermore, some way to ignore deleted images seems a good idea. Maybe an option to the Digikam constructor affecting all image queries.

The images property returns a SQLAlchemy Query (it is implemented as a dynamic relationship), so I think changing the all method is too complicated. Adding a default filter may be possible.

Would this be helpful to you (or others)?

Thanks again, and either or both of these would be helpful to me. I would also like to know if/how I can safely delete 'deleted' images from the table without upsetting referential integrity in some way, but that's not for here necessarily!

[rcw-2]

Returning None as abspath for images without an album seems logical, so it will be in the next version.

Implemented in v0.3.5.