From 8faf419fcf13e5f827c477dad1cfd9445e1388cd Mon Sep 17 00:00:00 2001 From: nxtumUbun Date: Mon, 16 Feb 2026 05:39:28 -0800 Subject: [PATCH 1/2] const for consistency --- interfaces/IAmazonPrime.h | 2 +- interfaces/IApplication.h | 2 +- interfaces/IBrowser.h | 6 +++--- interfaces/IComposition.h | 2 +- interfaces/IContentDecryption.h | 2 +- interfaces/IContentProtection.h | 2 +- interfaces/IDisplayInfo.h | 2 +- interfaces/IDolby.h | 2 +- interfaces/IExternal.h | 4 ++-- interfaces/IExternalBase.h | 2 +- interfaces/IGuide.h | 2 +- interfaces/IInputPin.h | 2 +- interfaces/ILISA.h | 2 +- interfaces/IMediaPlayer.h | 2 +- interfaces/INetflix.h | 2 +- interfaces/INetworkControl.h | 2 +- interfaces/IPackageManager.h | 2 +- interfaces/IProvisioning.h | 2 +- interfaces/IRPCLink.h | 2 +- interfaces/IRemoteControl.h | 2 +- interfaces/IStore.h | 2 +- interfaces/ISwitchBoard.h | 2 +- interfaces/ISystemAudioPlayer.h | 2 +- interfaces/ITextToSpeech.h | 2 +- interfaces/ITimeSync.h | 2 +- interfaces/ITimeZone.h | 2 +- interfaces/IWatermark.h | 2 +- interfaces/IWifiControl.h | 2 +- qa_interfaces/ITestController.h | 2 +- 29 files changed, 32 insertions(+), 32 deletions(-) diff --git a/interfaces/IAmazonPrime.h b/interfaces/IAmazonPrime.h index 0e5a9458..353c37d5 100644 --- a/interfaces/IAmazonPrime.h +++ b/interfaces/IAmazonPrime.h @@ -38,7 +38,7 @@ namespace Exchange { }; virtual void Register(IAmazonPrime::INotification* ignition) = 0; - virtual void Unregister(IAmazonPrime::INotification* ignition) = 0; + virtual void Unregister(const IAmazonPrime::INotification* ignition) = 0; // @brief Send a message over the message bus to ignition // @param messsage: The message to send according the amazon spec found diff --git a/interfaces/IApplication.h b/interfaces/IApplication.h index 8ce49533..286888fc 100644 --- a/interfaces/IApplication.h +++ b/interfaces/IApplication.h @@ -79,7 +79,7 @@ namespace Exchange { }; virtual void Register(INotification* sink) = 0; - virtual void Unregister(INotification* sink) = 0; + virtual void Unregister(const INotification* sink) = 0; // @brief Resets application data // @param type: Type of reset to perform diff --git a/interfaces/IBrowser.h b/interfaces/IBrowser.h index 3363880e..0ea500b1 100644 --- a/interfaces/IBrowser.h +++ b/interfaces/IBrowser.h @@ -42,7 +42,7 @@ namespace Exchange { }; virtual void Register(IBrowser::INotification* sink) = 0; - virtual void Unregister(IBrowser::INotification* sink) = 0; + virtual void Unregister(const IBrowser::INotification* sink) = 0; // Change the currently displayed URL by the browser. virtual void SetURL(const string& URL) = 0; @@ -96,7 +96,7 @@ namespace Exchange { }; virtual void Register(INotification* sink) = 0; - virtual void Unregister(INotification* sink) = 0; + virtual void Unregister(const INotification* sink) = 0; // @property // @brief Page loaded in the browser @@ -264,7 +264,7 @@ namespace Exchange { }; virtual void Register(INotification* sink) = 0; - virtual void Unregister(INotification* sink) = 0; + virtual void Unregister(const INotification* sink) = 0; // @property // @brief Get/Set CookieJar config details diff --git a/interfaces/IComposition.h b/interfaces/IComposition.h index 164c85ad..2698218c 100644 --- a/interfaces/IComposition.h +++ b/interfaces/IComposition.h @@ -110,7 +110,7 @@ namespace Exchange { }; virtual void Register(IComposition::INotification* notification) = 0; - virtual void Unregister(IComposition::INotification* notification) = 0; + virtual void Unregister(const IComposition::INotification* notification) = 0; virtual uint32_t Configure(PluginHost::IShell* service) = 0; diff --git a/interfaces/IContentDecryption.h b/interfaces/IContentDecryption.h index 6ca1b509..7e6cbcea 100644 --- a/interfaces/IContentDecryption.h +++ b/interfaces/IContentDecryption.h @@ -54,7 +54,7 @@ namespace Exchange { }; virtual uint32_t Register(IContentDecryption::INotification* notification VARIABLE_IS_NOT_USED) { return Core::ERROR_NOT_SUPPORTED; }; - virtual uint32_t Unregister(IContentDecryption::INotification* notification VARIABLE_IS_NOT_USED) { return Core::ERROR_NOT_SUPPORTED; }; + virtual uint32_t Unregister(const IContentDecryption::INotification* notification VARIABLE_IS_NOT_USED) { return Core::ERROR_NOT_SUPPORTED; }; }; class DataExchange : public Core::SharedBuffer { diff --git a/interfaces/IContentProtection.h b/interfaces/IContentProtection.h index c883c4ef..98026f09 100644 --- a/interfaces/IContentProtection.h +++ b/interfaces/IContentProtection.h @@ -75,7 +75,7 @@ namespace Exchange { }; virtual uint32_t Register(INotification* notification) = 0; - virtual uint32_t Unregister(INotification* notification) = 0; + virtual uint32_t Unregister(const INotification* notification) = 0; // @alt openDrmSession // @param clientId client that establishes the playback session diff --git a/interfaces/IDisplayInfo.h b/interfaces/IDisplayInfo.h index b819de91..4af62292 100644 --- a/interfaces/IDisplayInfo.h +++ b/interfaces/IDisplayInfo.h @@ -68,7 +68,7 @@ namespace Exchange { }; virtual uint32_t Register(INotification*) = 0; - virtual uint32_t Unregister(INotification*) = 0; + virtual uint32_t Unregister(const INotification*) = 0; // @property // @brief Current audio passthrough status on HDMI diff --git a/interfaces/IDolby.h b/interfaces/IDolby.h index 25002ce2..ec257a97 100644 --- a/interfaces/IDolby.h +++ b/interfaces/IDolby.h @@ -66,7 +66,7 @@ namespace Exchange { }; virtual uint32_t Register(INotification*) = 0; - virtual uint32_t Unregister(INotification*) = 0; + virtual uint32_t Unregister(const INotification*) = 0; // @property // @text dolbyatmossupported @alt:deprecated dolby_atmosmetadata diff --git a/interfaces/IExternal.h b/interfaces/IExternal.h index 79bf5199..50554f6c 100644 --- a/interfaces/IExternal.h +++ b/interfaces/IExternal.h @@ -45,7 +45,7 @@ namespace Exchange { // Pushing notifications to interested sinks virtual void Register(ICatalog::INotification* sink) = 0; - virtual void Unregister(ICatalog::INotification* sink) = 0; + virtual void Unregister(const ICatalog::INotification* sink) = 0; virtual IExternal* Resource(const uint32_t id) = 0; }; @@ -61,7 +61,7 @@ namespace Exchange { // Pushing notifications to interested sinks virtual void Register(INotification* sink) = 0; - virtual void Unregister(INotification* sink) = 0; + virtual void Unregister(const INotification* sink) = 0; // Element require communication, so might fail, report our condition virtual condition Condition() const = 0; diff --git a/interfaces/IExternalBase.h b/interfaces/IExternalBase.h index e278f321..973281d1 100644 --- a/interfaces/IExternalBase.h +++ b/interfaces/IExternalBase.h @@ -186,7 +186,7 @@ POP_WARNING() _adminLock.Unlock(); } - void Unregister(IExternal::INotification* sink) override + void Unregister(const IExternal::INotification* sink) override { _adminLock.Lock(); diff --git a/interfaces/IGuide.h b/interfaces/IGuide.h index f84c27db..05514afc 100644 --- a/interfaces/IGuide.h +++ b/interfaces/IGuide.h @@ -50,7 +50,7 @@ namespace Exchange { virtual bool IsParentalLocked(const string&) = 0; virtual void Register(IGuide::INotification*) = 0; - virtual void Unregister(IGuide::INotification*) = 0; + virtual void Unregister(const IGuide::INotification*) = 0; }; } } diff --git a/interfaces/IInputPin.h b/interfaces/IInputPin.h index 8ac8d09a..d62bbab6 100644 --- a/interfaces/IInputPin.h +++ b/interfaces/IInputPin.h @@ -44,7 +44,7 @@ namespace Exchange { ~IInputPin() override = default; virtual void Register(IInputPin::INotification* sink) = 0; - virtual void Unregister(IInputPin::INotification* sink) = 0; + virtual void Unregister(const IInputPin::INotification* sink) = 0; virtual void AddMarker(const uint32_t marker) = 0; virtual void RemoveMarker(const uint32_t marker) = 0; diff --git a/interfaces/ILISA.h b/interfaces/ILISA.h index 8f3a0d8f..ffba39dc 100644 --- a/interfaces/ILISA.h +++ b/interfaces/ILISA.h @@ -141,7 +141,7 @@ namespace Exchange { }; virtual uint32_t Register(ILISA::INotification* notification) = 0; - virtual uint32_t Unregister(ILISA::INotification* notification) = 0; + virtual uint32_t Unregister(const ILISA::INotification* notification) = 0; virtual uint32_t Configure(const std::string& config) = 0; struct EXTERNAL IAppVersion : virtual public Core::IUnknown { diff --git a/interfaces/IMediaPlayer.h b/interfaces/IMediaPlayer.h index 9686ccfa..93aace55 100644 --- a/interfaces/IMediaPlayer.h +++ b/interfaces/IMediaPlayer.h @@ -50,7 +50,7 @@ struct IMediaPlayer : virtual public Core::IUnknown { virtual uint32_t InitConfig(const string& configurationJson) = 0; virtual uint32_t InitDRMConfig(const string& configurationJson) = 0; virtual uint32_t Register(INotification* notification) = 0; - virtual uint32_t Unregister(INotification* notification) = 0; + virtual uint32_t Unregister(const INotification* notification) = 0; }; ~IMediaPlayer() override = default; diff --git a/interfaces/INetflix.h b/interfaces/INetflix.h index 467d09b6..127cdf7b 100644 --- a/interfaces/INetflix.h +++ b/interfaces/INetflix.h @@ -41,7 +41,7 @@ namespace Exchange { }; virtual void Register(INetflix::INotification* netflix) = 0; - virtual void Unregister(INetflix::INotification* netflix) = 0; + virtual void Unregister(const INetflix::INotification* netflix) = 0; virtual void SystemCommand(const string& command) = 0; }; diff --git a/interfaces/INetworkControl.h b/interfaces/INetworkControl.h index 1be54c19..99fed1b7 100644 --- a/interfaces/INetworkControl.h +++ b/interfaces/INetworkControl.h @@ -63,7 +63,7 @@ namespace Exchange { // Pushing notifications to interested sinks virtual uint32_t Register(INetworkControl::INotification* sink) = 0; - virtual uint32_t Unregister(INetworkControl::INotification* sink) = 0; + virtual uint32_t Unregister(const INetworkControl::INotification* sink) = 0; // @property // @brief Currently available interfaces diff --git a/interfaces/IPackageManager.h b/interfaces/IPackageManager.h index 9130fb2c..a58c8da8 100644 --- a/interfaces/IPackageManager.h +++ b/interfaces/IPackageManager.h @@ -190,7 +190,7 @@ namespace Exchange { }; virtual uint32_t Register(IPackageManager::INotification* notification) = 0; - virtual uint32_t Unregister(IPackageManager::INotification* notification) = 0; + virtual uint32_t Unregister(const IPackageManager::INotification* notification) = 0; struct EXTERNAL PackageKey { string id /* @brief Unique identifier of the package */; diff --git a/interfaces/IProvisioning.h b/interfaces/IProvisioning.h index 4c86af7c..fa36771b 100644 --- a/interfaces/IProvisioning.h +++ b/interfaces/IProvisioning.h @@ -36,7 +36,7 @@ namespace Exchange { }; virtual void Register(IProvisioning::INotification* provisioning) = 0; - virtual void Unregister(IProvisioning::INotification* provisioning) = 0; + virtual void Unregister(const IProvisioning::INotification* provisioning) = 0; virtual uint32_t DeviceId (string& deviceId /* @out */) const = 0; virtual uint32_t DRMId (const string& label /* @in */, uint16_t& size /* @inout */, uint8_t data[] /* @length:size @out */) const = 0; }; diff --git a/interfaces/IRPCLink.h b/interfaces/IRPCLink.h index d025ec6a..24c3576f 100644 --- a/interfaces/IRPCLink.h +++ b/interfaces/IRPCLink.h @@ -35,7 +35,7 @@ namespace Exchange { }; virtual void Register(INotification* notification) = 0; - virtual void Unregister(INotification* notification) = 0; + virtual void Unregister(const INotification* notification) = 0; virtual uint32_t Start(const uint32_t id, const string& name) = 0; virtual uint32_t Stop() = 0; diff --git a/interfaces/IRemoteControl.h b/interfaces/IRemoteControl.h index f5c06acf..958a1d24 100644 --- a/interfaces/IRemoteControl.h +++ b/interfaces/IRemoteControl.h @@ -38,7 +38,7 @@ namespace Exchange { }; virtual void RegisterEvents(INotification* sink) = 0; - virtual void UnregisterEvents(INotification* sink) = 0; + virtual void UnregisterEvents(const INotification* sink) = 0; }; } } diff --git a/interfaces/IStore.h b/interfaces/IStore.h index c4950e85..738f9878 100644 --- a/interfaces/IStore.h +++ b/interfaces/IStore.h @@ -35,7 +35,7 @@ struct EXTERNAL IStore : virtual public Core::IUnknown { }; virtual uint32_t Register(Exchange::IStore::INotification *notification) = 0; - virtual uint32_t Unregister(Exchange::IStore::INotification *notification) = 0; + virtual uint32_t Unregister(const Exchange::IStore::INotification *notification) = 0; virtual uint32_t SetValue(const string &ns, const string &key, const string &value) = 0; virtual uint32_t GetValue(const string &ns, const string &key, string &value /* @out */) = 0; virtual uint32_t DeleteKey(const string &ns, const string &key) = 0; diff --git a/interfaces/ISwitchBoard.h b/interfaces/ISwitchBoard.h index e64c3e18..b6d6cc67 100644 --- a/interfaces/ISwitchBoard.h +++ b/interfaces/ISwitchBoard.h @@ -37,7 +37,7 @@ namespace Exchange { }; virtual void Register(INotification* notification) = 0; - virtual void Unregister(INotification* notification) = 0; + virtual void Unregister(const INotification* notification) = 0; virtual bool IsActive(const string& callsign) const = 0; virtual uint32_t Activate(const string& callsign) = 0; diff --git a/interfaces/ISystemAudioPlayer.h b/interfaces/ISystemAudioPlayer.h index 1644f2f3..110e595a 100644 --- a/interfaces/ISystemAudioPlayer.h +++ b/interfaces/ISystemAudioPlayer.h @@ -38,7 +38,7 @@ namespace Exchange { virtual uint32_t Configure(PluginHost::IShell* service) = 0; virtual void Register(INotification* sink) = 0; - virtual void Unregister(INotification* sink) = 0; + virtual void Unregister(const INotification* sink) = 0; virtual uint32_t Open(const string &input, string &output /* @out */) = 0; virtual uint32_t Play(const string &input, string &output /* @out */) = 0; diff --git a/interfaces/ITextToSpeech.h b/interfaces/ITextToSpeech.h index c509d0be..9c9b8d20 100644 --- a/interfaces/ITextToSpeech.h +++ b/interfaces/ITextToSpeech.h @@ -66,7 +66,7 @@ namespace Exchange { ~ITextToSpeech() override = default; virtual void Register(ITextToSpeech::INotification* sink) = 0; - virtual void Unregister(ITextToSpeech::INotification* sink) = 0; + virtual void Unregister(const ITextToSpeech::INotification* sink) = 0; // @property // @brief Query the status/enable tts diff --git a/interfaces/ITimeSync.h b/interfaces/ITimeSync.h index 2ba12966..e30f5dfd 100644 --- a/interfaces/ITimeSync.h +++ b/interfaces/ITimeSync.h @@ -42,7 +42,7 @@ namespace Exchange { }; virtual void Register(INotification* notification) = 0; - virtual void Unregister(INotification* notification) = 0; + virtual void Unregister(const INotification* notification) = 0; virtual uint32_t Synchronize() = 0; virtual void Cancel() = 0; diff --git a/interfaces/ITimeZone.h b/interfaces/ITimeZone.h index a5a15278..2f0b1526 100644 --- a/interfaces/ITimeZone.h +++ b/interfaces/ITimeZone.h @@ -39,7 +39,7 @@ namespace Exchange { }; virtual uint32_t Register(ITimeZone::INotification* sink) = 0; - virtual uint32_t Unregister(ITimeZone::INotification* sink) = 0; + virtual uint32_t Unregister(const ITimeZone::INotification* sink) = 0; // @property // @brief TimeZone for system diff --git a/interfaces/IWatermark.h b/interfaces/IWatermark.h index 41096f20..b8e81388 100644 --- a/interfaces/IWatermark.h +++ b/interfaces/IWatermark.h @@ -32,7 +32,7 @@ namespace Exchange { virtual uint32_t Initialize(string waylandDisplay, bool synchronized) = 0; virtual uint32_t Deinitialize() = 0; virtual uint32_t Register(INotification* notification) = 0; - virtual uint32_t Unregister(INotification* notification) = 0; + virtual uint32_t Unregister(const INotification* notification) = 0; virtual bool ShowWatermark(const bool show) = 0; virtual bool CreateWatermark(uint32_t id, uint32_t zorder) = 0; virtual bool UpdateWatermark(uint32_t id, uint32_t key, uint32_t size) = 0; diff --git a/interfaces/IWifiControl.h b/interfaces/IWifiControl.h index 99fc1bdb..827ce31e 100644 --- a/interfaces/IWifiControl.h +++ b/interfaces/IWifiControl.h @@ -95,7 +95,7 @@ namespace Exchange { // Pushing notifications to interested sinks virtual uint32_t Register(IWifiControl::INotification* sink) = 0; - virtual uint32_t Unregister(IWifiControl::INotification* sink) = 0; + virtual uint32_t Unregister(const IWifiControl::INotification* sink) = 0; // @property // @brief Provides available networks information diff --git a/qa_interfaces/ITestController.h b/qa_interfaces/ITestController.h index 72797c3f..b071f9ff 100644 --- a/qa_interfaces/ITestController.h +++ b/qa_interfaces/ITestController.h @@ -64,7 +64,7 @@ namespace Thunder { virtual void TearDown() = 0; virtual void Register(ITest* test) = 0; - virtual void Unregister(ITest* test) = 0; + virtual void Unregister(const ITest* test) = 0; virtual ITest::IIterator* Tests() const = 0; virtual ITest* Test(const string& name) const = 0; }; From 652665ea5052f161bedbef0e4a5603560edae9cc Mon Sep 17 00:00:00 2001 From: nxtumUbun Date: Mon, 16 Feb 2026 06:37:15 -0800 Subject: [PATCH 2/2] add istore2.h --- interfaces/IStore2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/interfaces/IStore2.h b/interfaces/IStore2.h index 1e08f78c..276dd189 100644 --- a/interfaces/IStore2.h +++ b/interfaces/IStore2.h @@ -48,7 +48,7 @@ namespace Exchange { }; virtual uint32_t Register(Exchange::IStore2::INotification* notification) = 0; - virtual uint32_t Unregister(Exchange::IStore2::INotification* notification) = 0; + virtual uint32_t Unregister(const Exchange::IStore2::INotification* notification) = 0; // @alt setValue virtual uint32_t SetValue(const ScopeType scope, const string& ns /* @text:namespace */, const string& key, const string& value, const uint32_t ttl) = 0;