From 29fa3b70c28e6e389b7f99756903490dbeba44ad Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 19 May 2026 10:38:47 +0000 Subject: [PATCH 1/4] Initial plan From 1cbf96e38f605dd20abf38cf33dd78d6b28b9806 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 19 May 2026 10:41:21 +0000 Subject: [PATCH 2/4] fix(utests): link PlayerCommonTests with pkg-config GST imported target Agent-Logs-Url: https://github.com/rdkcentral/middleware-player-interface/sessions/6b523a0e-e7b9-415b-8870-92d8e5911365 Co-authored-by: dp0000 <53818367+dp0000@users.noreply.github.com> --- test/utests/tests/PlayerCommonTests/CMakeLists.txt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/test/utests/tests/PlayerCommonTests/CMakeLists.txt b/test/utests/tests/PlayerCommonTests/CMakeLists.txt index 73f044f6..f74b4578 100644 --- a/test/utests/tests/PlayerCommonTests/CMakeLists.txt +++ b/test/utests/tests/PlayerCommonTests/CMakeLists.txt @@ -90,11 +90,16 @@ endif() find_package(PkgConfig REQUIRED) pkg_check_modules(GST REQUIRED + IMPORTED_TARGET gstreamer-1.0 gstreamer-base-1.0 gstreamer-app-1.0 ) -target_link_libraries(${EXEC_NAME} fakes -pthread ${GLIB_LINK_LIBRARIES} ${OS_LD_FLAGS} ${GMOCK_LINK_LIBRARIES} ${GTEST_LINK_LIBRARIES} ${GST_LIBRARIES}) +if (CMAKE_SYSTEM_NAME STREQUAL Darwin) + message(STATUS "PlayerCommonTests: linking GStreamer via pkg-config imported target (PkgConfig::GST). If configuration fails, ensure gstreamer and gst-plugins-base are installed and discoverable via PKG_CONFIG_PATH.") +endif() + +target_link_libraries(${EXEC_NAME} fakes -pthread ${GLIB_LINK_LIBRARIES} ${OS_LD_FLAGS} ${GMOCK_LINK_LIBRARIES} ${GTEST_LINK_LIBRARIES} PkgConfig::GST) player_utest_run_add(${EXEC_NAME}) From 878bc9bc24380a1b21806168fc1b81cc1cf4ff14 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 19 May 2026 10:42:05 +0000 Subject: [PATCH 3/4] chore(utests): clarify Darwin-specific GStreamer diagnostic Agent-Logs-Url: https://github.com/rdkcentral/middleware-player-interface/sessions/6b523a0e-e7b9-415b-8870-92d8e5911365 Co-authored-by: dp0000 <53818367+dp0000@users.noreply.github.com> --- test/utests/tests/PlayerCommonTests/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/utests/tests/PlayerCommonTests/CMakeLists.txt b/test/utests/tests/PlayerCommonTests/CMakeLists.txt index f74b4578..cc8f2cb0 100644 --- a/test/utests/tests/PlayerCommonTests/CMakeLists.txt +++ b/test/utests/tests/PlayerCommonTests/CMakeLists.txt @@ -97,7 +97,7 @@ pkg_check_modules(GST REQUIRED ) if (CMAKE_SYSTEM_NAME STREQUAL Darwin) - message(STATUS "PlayerCommonTests: linking GStreamer via pkg-config imported target (PkgConfig::GST). If configuration fails, ensure gstreamer and gst-plugins-base are installed and discoverable via PKG_CONFIG_PATH.") + message(STATUS "PlayerCommonTests: on Darwin, linking GStreamer via pkg-config imported target (PkgConfig::GST). If configuration fails, ensure gstreamer and gst-plugins-base are installed and discoverable via PKG_CONFIG_PATH.") endif() target_link_libraries(${EXEC_NAME} fakes -pthread ${GLIB_LINK_LIBRARIES} ${OS_LD_FLAGS} ${GMOCK_LINK_LIBRARIES} ${GTEST_LINK_LIBRARIES} PkgConfig::GST) From 79a3b2b77efebce1045e977df27c0f2cc8985c6b Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 19 May 2026 10:42:44 +0000 Subject: [PATCH 4/4] refactor(utests): remove noisy Darwin status output Agent-Logs-Url: https://github.com/rdkcentral/middleware-player-interface/sessions/6b523a0e-e7b9-415b-8870-92d8e5911365 Co-authored-by: dp0000 <53818367+dp0000@users.noreply.github.com> --- test/utests/tests/PlayerCommonTests/CMakeLists.txt | 4 ---- 1 file changed, 4 deletions(-) diff --git a/test/utests/tests/PlayerCommonTests/CMakeLists.txt b/test/utests/tests/PlayerCommonTests/CMakeLists.txt index cc8f2cb0..02f0ad57 100644 --- a/test/utests/tests/PlayerCommonTests/CMakeLists.txt +++ b/test/utests/tests/PlayerCommonTests/CMakeLists.txt @@ -96,10 +96,6 @@ pkg_check_modules(GST REQUIRED gstreamer-app-1.0 ) -if (CMAKE_SYSTEM_NAME STREQUAL Darwin) - message(STATUS "PlayerCommonTests: on Darwin, linking GStreamer via pkg-config imported target (PkgConfig::GST). If configuration fails, ensure gstreamer and gst-plugins-base are installed and discoverable via PKG_CONFIG_PATH.") -endif() - target_link_libraries(${EXEC_NAME} fakes -pthread ${GLIB_LINK_LIBRARIES} ${OS_LD_FLAGS} ${GMOCK_LINK_LIBRARIES} ${GTEST_LINK_LIBRARIES} PkgConfig::GST) player_utest_run_add(${EXEC_NAME})