From b3b280201c96de276ed162af9592b432c05d3614 Mon Sep 17 00:00:00 2001 From: nrames759 Date: Tue, 10 Feb 2026 13:20:29 +0530 Subject: [PATCH 1/6] ISSUES TEMPLATE --- .../player_interface_change_request.yml | 81 +++++++++++++++++++ github/middleware_change_request.yml | 81 +++++++++++++++++++ 2 files changed, 162 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/player_interface_change_request.yml create mode 100644 github/middleware_change_request.yml diff --git a/.github/ISSUE_TEMPLATE/player_interface_change_request.yml b/.github/ISSUE_TEMPLATE/player_interface_change_request.yml new file mode 100644 index 00000000..08a35ace --- /dev/null +++ b/.github/ISSUE_TEMPLATE/player_interface_change_request.yml @@ -0,0 +1,81 @@ +name: Middleware Player Interface Change Request +description: Change Request for Middleware Player Interface +title: ": " +labels: ["MW Change Request"] +body: + - type: markdown + attributes: + value: | + Change Request for Middleware Player Interface + + - type: textarea + id: description + attributes: + label: Description + description: Provide a clear and concise description of the feature or bug ticket + placeholder: Describe the changes you are bringing + validations: + required: true + + - type: textarea + id: additional-context + attributes: + label: Additional Context + description: Add any other context, screenshots, or examples about the feature request + placeholder: Any other relevant information + validations: + required: false + + - type: textarea + id: dod-checklist + attributes: + label: Definition of Done (DoD) + description: Mark items with [x] and replace the placeholder text on Details lines with actual information. + value: | + Please complete the following Middleware Layer Integration checklist items to ensure all requirements for changes to be merged. + + **IMPORTANT:** Do NOT provide any proprietary information including: + - Links to internal Automatics/CI builds + - Links to internal Confluence pages + - Any other Comcast/Sky proprietary or confidential information + - Development Build/Setup Details + + Only provide publicly accessible information and links. All proprietary information should be added to JIRA Ticket. + + --- + + - [ ] **Middleware component tags with changelog** + - Details: For instance https://github.com/rdkcentral/hdmicec/blob/1.0.7/CHANGELOG.md. Include all components that need to go together for Builds to work. + + - [ ] **Tested on STBs** + + - [ ] **Tested on TVs** + + - [ ] **Dependent Layer tags (App Layer, OSS, Product, Halif Headers, Vendor Layers)** + - Details: (e.g. https://github.com/rdk-e/meta-image-support/blob/4.1.1/CHANGELOG.md) + + - [ ] **Do Widgets Need Publishing** + - Details: (Provide context if widgets are involved) + + - [ ] **Copilot review for Components** + - Details: (Any comments on the review) + + - [ ] **Component Test** + - Details: Share Testing done as part of components release + + - [ ] **Integration Testing** + - Details: Provide details on Integration testing done within Middleware layer + + - [ ] **E2E Testing** + - Details: Provide details on end to end testing done across all layers + + - [ ] **Performance Testing** + - Details: Provide details on performance testing done + + - [ ] **Static code analysis/Coverity** + - Details: Share Coverity runs for components affected + + - [ ] **Manual Functional Test** + + validations: + required: true diff --git a/github/middleware_change_request.yml b/github/middleware_change_request.yml new file mode 100644 index 00000000..3ba35e28 --- /dev/null +++ b/github/middleware_change_request.yml @@ -0,0 +1,81 @@ +name: RDK-E Middleware Change Request +description: Change Request for RDK-E Middleware +title: ": " +labels: ["MW Change Request"] +body: + - type: markdown + attributes: + value: | + Change Request for RDK-E Middleware + + - type: textarea + id: description + attributes: + label: Description + description: Provide a clear and concise description of the feature or bug ticket + placeholder: Describe the changes you are bringing + validations: + required: true + + - type: textarea + id: additional-context + attributes: + label: Additional Context + description: Add any other context, screenshots, or examples about the feature request + placeholder: Any other relevant information + validations: + required: false + + - type: textarea + id: dod-checklist + attributes: + label: Definition of Done (DoD) + description: Mark items with [x] and replace the placeholder text on Details lines with actual information. + value: | + Please complete the following Middleware Layer Integration checklist items to ensure all requirements for changes to be merged. + + **IMPORTANT:** Do NOT provide any proprietary information including: + - Links to internal Automatics/CI builds + - Links to internal Confluence pages + - Any other Comcast/Sky proprietary or confidential information + - Development Build/Setup Details + + Only provide publicly accessible information and links. All proprietary information should be added to JIRA Ticket. + + --- + + - [ ] **Middleware component tags with changelog** + - Details: For instance https://github.com/rdkcentral/hdmicec/blob/1.0.7/CHANGELOG.md. Include all components that need to go together for Builds to work. + + - [ ] **Tested on STBs** + + - [ ] **Tested on TVs** + + - [ ] **Dependent Layer tags (App Layer, OSS, Product, Halif Headers, Vendor Layers)** + - Details: (e.g. https://github.com/rdk-e/meta-image-support/blob/4.1.1/CHANGELOG.md) + + - [ ] **Do Widgets Need Publishing** + - Details: (Provide context if widgets are involved) + + - [ ] **Copilot review for Components** + - Details: (Any comments on the review) + + - [ ] **Component Test** + - Details: Share Testing done as part of components release + + - [ ] **Integration Testing** + - Details: Provide details on Integration testing done within Middleware layer + + - [ ] **E2E Testing** + - Details: Provide details on end to end testing done across all layers + + - [ ] **Performance Testing** + - Details: Provide details on performance testing done + + - [ ] **Static code analysis/Coverity** + - Details: Share Coverity runs for components affected + + - [ ] **Manual Functional Test** + + validations: + required: true From b6312936f280f152c08542e9d9d4b2a73d973e08 Mon Sep 17 00:00:00 2001 From: nrames759 Date: Tue, 10 Feb 2026 13:21:15 +0530 Subject: [PATCH 2/6] remove mistaken file --- github/middleware_change_request.yml | 81 ---------------------------- 1 file changed, 81 deletions(-) delete mode 100644 github/middleware_change_request.yml diff --git a/github/middleware_change_request.yml b/github/middleware_change_request.yml deleted file mode 100644 index 3ba35e28..00000000 --- a/github/middleware_change_request.yml +++ /dev/null @@ -1,81 +0,0 @@ -name: RDK-E Middleware Change Request -description: Change Request for RDK-E Middleware -title: ": " -labels: ["MW Change Request"] -body: - - type: markdown - attributes: - value: | - Change Request for RDK-E Middleware - - - type: textarea - id: description - attributes: - label: Description - description: Provide a clear and concise description of the feature or bug ticket - placeholder: Describe the changes you are bringing - validations: - required: true - - - type: textarea - id: additional-context - attributes: - label: Additional Context - description: Add any other context, screenshots, or examples about the feature request - placeholder: Any other relevant information - validations: - required: false - - - type: textarea - id: dod-checklist - attributes: - label: Definition of Done (DoD) - description: Mark items with [x] and replace the placeholder text on Details lines with actual information. - value: | - Please complete the following Middleware Layer Integration checklist items to ensure all requirements for changes to be merged. - - **IMPORTANT:** Do NOT provide any proprietary information including: - - Links to internal Automatics/CI builds - - Links to internal Confluence pages - - Any other Comcast/Sky proprietary or confidential information - - Development Build/Setup Details - - Only provide publicly accessible information and links. All proprietary information should be added to JIRA Ticket. - - --- - - - [ ] **Middleware component tags with changelog** - - Details: For instance https://github.com/rdkcentral/hdmicec/blob/1.0.7/CHANGELOG.md. Include all components that need to go together for Builds to work. - - - [ ] **Tested on STBs** - - - [ ] **Tested on TVs** - - - [ ] **Dependent Layer tags (App Layer, OSS, Product, Halif Headers, Vendor Layers)** - - Details: (e.g. https://github.com/rdk-e/meta-image-support/blob/4.1.1/CHANGELOG.md) - - - [ ] **Do Widgets Need Publishing** - - Details: (Provide context if widgets are involved) - - - [ ] **Copilot review for Components** - - Details: (Any comments on the review) - - - [ ] **Component Test** - - Details: Share Testing done as part of components release - - - [ ] **Integration Testing** - - Details: Provide details on Integration testing done within Middleware layer - - - [ ] **E2E Testing** - - Details: Provide details on end to end testing done across all layers - - - [ ] **Performance Testing** - - Details: Provide details on performance testing done - - - [ ] **Static code analysis/Coverity** - - Details: Share Coverity runs for components affected - - - [ ] **Manual Functional Test** - - validations: - required: true From 018e76b7185eecde24ff18724e800c689c615349 Mon Sep 17 00:00:00 2001 From: nrames759 Date: Tue, 10 Feb 2026 13:31:55 +0530 Subject: [PATCH 3/6] copilot review comments 01 --- .github/ISSUE_TEMPLATE/player_interface_change_request.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/player_interface_change_request.yml b/.github/ISSUE_TEMPLATE/player_interface_change_request.yml index 08a35ace..1ed39c51 100644 --- a/.github/ISSUE_TEMPLATE/player_interface_change_request.yml +++ b/.github/ISSUE_TEMPLATE/player_interface_change_request.yml @@ -1,6 +1,6 @@ name: Middleware Player Interface Change Request description: Change Request for Middleware Player Interface -title: ": " +title: ":" labels: ["MW Change Request"] body: - type: markdown @@ -67,7 +67,7 @@ body: - Details: Provide details on Integration testing done within Middleware layer - [ ] **E2E Testing** - - Details: Provide details on end to end testing done across all layers + - Details: Provide details on end-to-end testing done across all layers - [ ] **Performance Testing** - Details: Provide details on performance testing done From ebe80791e5d2fcf1caa36ad6eb374625d0a2931d Mon Sep 17 00:00:00 2001 From: nrames759 Date: Tue, 17 Feb 2026 14:38:50 +0530 Subject: [PATCH 4/6] L1 tests fix 01 --- .github/workflows/L1-tests.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/L1-tests.yml b/.github/workflows/L1-tests.yml index cd1a22c8..6804de2f 100644 --- a/.github/workflows/L1-tests.yml +++ b/.github/workflows/L1-tests.yml @@ -4,6 +4,7 @@ on: pull_request: branches: [develop, main] paths: ['**/*.c', '**/*.cpp', '**/*.cc', '**/*.cxx', '**/*.h', '**/*.hpp', '**/*.sh'] + workflow_dispatch: jobs: execute-unit-tests-on-pr: @@ -20,7 +21,7 @@ jobs: # Run L1 tests - name: Run unit tests with coverage working-directory: ./test/utests - run: ./run.sh -c + run: ./run.sh # Publish test results - name: Publish L1 test results From 8ddc438142e0486b74048126ee02d3d058758256 Mon Sep 17 00:00:00 2001 From: nrames759 Date: Tue, 17 Feb 2026 14:51:07 +0530 Subject: [PATCH 5/6] L1 test update --- .github/workflows/L1-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/L1-tests.yml b/.github/workflows/L1-tests.yml index 6804de2f..ed93d84c 100644 --- a/.github/workflows/L1-tests.yml +++ b/.github/workflows/L1-tests.yml @@ -8,7 +8,7 @@ on: jobs: execute-unit-tests-on-pr: - name: Runs all unit tests + name: Runs all unit tests - L1 runs-on: ubuntu-latest steps: @@ -19,7 +19,7 @@ jobs: run: yes | ./install-middleware.sh -s subtec # Run L1 tests - - name: Run unit tests with coverage + - name: Run unit tests - L1 working-directory: ./test/utests run: ./run.sh From 828dda7abbc624b0958239ae9b774521a4916bfe Mon Sep 17 00:00:00 2001 From: nrames759 Date: Tue, 17 Feb 2026 15:17:09 +0530 Subject: [PATCH 6/6] reset coverage run --- .github/workflows/L1-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/L1-tests.yml b/.github/workflows/L1-tests.yml index ed93d84c..32782833 100644 --- a/.github/workflows/L1-tests.yml +++ b/.github/workflows/L1-tests.yml @@ -19,9 +19,9 @@ jobs: run: yes | ./install-middleware.sh -s subtec # Run L1 tests - - name: Run unit tests - L1 + - name: Run unit tests with coverage - L1 working-directory: ./test/utests - run: ./run.sh + run: ./run.sh -c # Publish test results - name: Publish L1 test results