-
Notifications
You must be signed in to change notification settings - Fork 1
Consolidate PR review/rework pipelines — eliminate redundancy #705
Copy link
Copy link
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Problem
We have 4 overlapping pipelines for the PR review→fix→reply cycle:
| Pipeline | Type | Steps |
|---|---|---|
ops-pr-review |
Leaf | Review PR, post findings |
ops-pr-rework |
Leaf | Fetch → triage → fix → push (no reply, uses git add -A) |
ops-pr-fix-review |
Leaf | Fetch → triage → fix → push → reply (superset of rework) |
impl-review-loop |
Composition | impl-issue → ops-pr-review → ops-pr-rework → re-review |
ops-pr-fix-review is a strict superset of ops-pr-rework. impl-review-loop hardcodes 2 iterations and chains leaf pipelines that already overlap.
Proposal
Leaf pipelines (granular, composable)
ops-pr-review(keep, existing) — Review a PR, produce structured findings artifactops-pr-triage(new, extracted from rework) — Classify findings as accept/reject/defer/skipops-pr-fix(new, extracted from rework) — Apply accepted fixes, run tests, commit, pushops-pr-reply(new) — Post per-comment resolutions and summary on the PR
Composition pipelines (wire leafs together)
ops-pr-rework→ composition of:ops-pr-triage→ops-pr-fixops-pr-fix-review→ composition of:ops-pr-review→ops-pr-triage→ops-pr-fix→ops-pr-replyimpl-review-loop→ composition of:impl-issue→ops-pr-fix-review(with loop/iteration config)
Cleanup
- Delete current monolithic
ops-pr-rework.yaml(replace with composition version) - Delete current monolithic
ops-pr-fix-review.yaml(replace with composition version) - Fix
git add -A→ targeted staging inops-pr-fix - Include GitHub Copilot/bot reviews in
ops-pr-reviewandops-pr-triage
Design principles
- Each leaf pipeline does ONE thing (single responsibility)
- Composition pipelines are thin orchestrations — no inline logic
- Same leaf steps are reusable across different compositions
- Loop iterations handled by composition config, not hardcoded steps
Acceptance criteria
- Extract 4 leaf pipelines from existing code
- Rewrite 3 composition pipelines as thin orchestrations
- Delete monolithic
ops-pr-rework.yamlandops-pr-fix-review.yaml -
git add -Areplaced with targeted staging - Copilot/bot reviews included in review extraction
- All existing pipelines that reference
ops-pr-reworkupdated -
wave validatepasses on all new pipelines
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request