Skip to content

Commit 1be8527

Browse files
j-piaseckifacebook-github-bot
authored andcommitted
Add tests for isHermesV1Enabled (#53601)
Summary: Pull Request resolved: #53601 Changelog: [Internal] Adds tests covering the `isHermesV1Enabled` utility function. Reviewed By: cortinico Differential Revision: D81681635 fbshipit-source-id: c2c50db65f93b8b58ce1730ccfdf4367a024ce7b
1 parent a50ddf3 commit 1be8527

1 file changed

Lines changed: 27 additions & 0 deletions

File tree

  • packages/gradle-plugin/react-native-gradle-plugin/src/test/kotlin/com/facebook/react/utils

packages/gradle-plugin/react-native-gradle-plugin/src/test/kotlin/com/facebook/react/utils/ProjectUtilsTest.kt

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import com.facebook.react.tests.createProject
1414
import com.facebook.react.utils.ProjectUtils.getReactNativeArchitectures
1515
import com.facebook.react.utils.ProjectUtils.isEdgeToEdgeEnabled
1616
import com.facebook.react.utils.ProjectUtils.isHermesEnabled
17+
import com.facebook.react.utils.ProjectUtils.isHermesV1Enabled
1718
import com.facebook.react.utils.ProjectUtils.isNewArchEnabled
1819
import com.facebook.react.utils.ProjectUtils.needsCodegenFromPackageJson
1920
import java.io.File
@@ -115,6 +116,32 @@ class ProjectUtilsTest {
115116
assertThat(project.isEdgeToEdgeEnabled).isFalse()
116117
}
117118

119+
@Test
120+
fun isHermesV1Enabled_returnsFalseByDefault() {
121+
assertThat(createProject().isHermesV1Enabled).isFalse()
122+
}
123+
124+
@Test
125+
fun isHermesV1Enabled_withDisabledViaProperty_returnsFalse() {
126+
val project = createProject()
127+
project.extensions.extraProperties.set("hermesV1Enabled", "false")
128+
assertThat(project.isHermesV1Enabled).isFalse()
129+
}
130+
131+
@Test
132+
fun isHermesV1Enabled_withEnabledViaProperty_returnsTrue() {
133+
val project = createProject()
134+
project.extensions.extraProperties.set("hermesV1Enabled", "true")
135+
assertThat(project.isHermesV1Enabled).isTrue()
136+
}
137+
138+
@Test
139+
fun isHermesV1Enabled_withInvalidViaProperty_returnsFalse() {
140+
val project = createProject()
141+
project.extensions.extraProperties.set("hermesV1Enabled", "¯\\_(ツ)_/¯")
142+
assertThat(project.isHermesV1Enabled).isFalse()
143+
}
144+
118145
@Test
119146
fun needsCodegenFromPackageJson_withCodegenConfigInPackageJson_returnsTrue() {
120147
val project = createProject()

0 commit comments

Comments
 (0)