Skip to content

Commit 1c39b2a

Browse files
cipolleschifabriziocucci
authored andcommitted
Bump windows to latests as GH will remove windows-2019 EOM (#51798)
Summary: As per title, GH is [removing windows-2019](https://github.com/facebook/react-native/actions/runs/15421451006/job/43403215354) at the end of the month. We need to migrate away from them. ## Changelog: [Internal] - Bump windows runners Pull Request resolved: #51798 Test Plan: GHA Reviewed By: cortinico Differential Revision: D75946994 Pulled By: cipolleschi fbshipit-source-id: 972b60300c918c0eae0403ed4149347a4ffa8bd0
1 parent 4d346e2 commit 1c39b2a

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/actions/build-hermesc-windows/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ runs:
2525
- name: Windows cache
2626
uses: actions/cache@v4
2727
with:
28-
key: v2-hermes-${{ github.job }}-windows-${{ inputs.hermes-version }}-${{ inputs.react-native-version }}
28+
key: v3-hermes-${{ github.job }}-windows-${{ inputs.hermes-version }}-${{ inputs.react-native-version }}
2929
path: |
3030
D:\tmp\hermes\win64-bin\
3131
D:\tmp\hermes\hermes\icu\
@@ -63,7 +63,7 @@ runs:
6363
$Env:PATH += ";$Env:CMAKE_DIR;$Env:MSBUILD_DIR"
6464
$Env:ICU_ROOT = "$Env:HERMES_WS_DIR\icu"
6565
66-
cmake -S hermes -B build_release -G 'Visual Studio 16 2019' -Ax64 -DCMAKE_BUILD_TYPE=Release -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=True -DHERMES_ENABLE_WIN10_ICU_FALLBACK=OFF
66+
cmake -S hermes -B build_release -G 'Visual Studio 17 2022' -Ax64 -DCMAKE_BUILD_TYPE=Release -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=True -DHERMES_ENABLE_WIN10_ICU_FALLBACK=OFF
6767
if (-not $?) { throw "Failed to configure Hermes" }
6868
echo "Running windows build..."
6969
cd build_release

.github/workflows/nightly.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ jobs:
120120
react-native-version: ${{ needs.prepare_hermes_workspace.outputs.react-native-version }}
121121

122122
build_hermesc_windows:
123-
runs-on: windows-2019
123+
runs-on: windows-2025
124124
needs: prepare_hermes_workspace
125125
env:
126126
HERMES_WS_DIR: 'D:\tmp\hermes'

.github/workflows/publish-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ jobs:
116116
react-native-version: ${{ needs.prepare_hermes_workspace.outputs.react-native-version }}
117117

118118
build_hermesc_windows:
119-
runs-on: windows-2019
119+
runs-on: windows-2025
120120
needs: prepare_hermes_workspace
121121
env:
122122
HERMES_WS_DIR: 'D:\tmp\hermes'

.github/workflows/test-all.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ jobs:
424424
react-native-version: ${{ needs.prepare_hermes_workspace.outputs.react-native-version }}
425425

426426
build_hermesc_windows:
427-
runs-on: windows-2019
427+
runs-on: windows-2025
428428
needs: prepare_hermes_workspace
429429
env:
430430
HERMES_WS_DIR: 'D:\tmp\hermes'

0 commit comments

Comments
 (0)