Construct FBImagePerfImageInfo and pass to completion handler from within FBIconModule (#51110)

Aaron Coplan · facebook-github-bot · commit 2562440385a4 · 2025-05-05T16:37:56.000-07:00
Summary: Pull Request resolved: #51110 Changelog: [iOS][Changed] Update RCTImageLoader.mm to cast loadHandler to RCTImageLoaderLoggable before calling shouldEnablePerfLogging Replacing cast from RCTImageURLLoaderWithAttribution to RCTImageLoaderLoggable Reviewed By: philIip Differential Revision: D73148595 fbshipit-source-id: 01f61bc60624e2bb9cb4ff9b45094e38ea77dcaa
diff --git a/packages/react-native/Libraries/Image/RCTImageLoader.mm b/packages/react-native/Libraries/Image/RCTImageLoader.mm
@@ -911,7 +911,7 @@ - (BOOL)shouldEnablePerfLoggingForRequestUrl:(NSURL *)url
 {
   id<RCTImageURLLoader> loadHandler = [self imageURLLoaderForURL:url];
   if ([loadHandler respondsToSelector:@selector(shouldEnablePerfLogging)]) {
-    return [(id<RCTImageURLLoaderWithAttribution>)loadHandler shouldEnablePerfLogging];
+    return [(id<RCTImageLoaderLoggable>)loadHandler shouldEnablePerfLogging];
   }
   return NO;
 }

Original file line number	Diff line number	Diff line change
`@@ -911,7 +911,7 @@ - (BOOL)shouldEnablePerfLoggingForRequestUrl:(NSURL *)url`
`911`	`911`	`{`
`912`	`912`	`id<RCTImageURLLoader> loadHandler = [self imageURLLoaderForURL:url];`
`913`	`913`	`if ([loadHandler respondsToSelector:@selector(shouldEnablePerfLogging)]) {`
`914`		`- return [(id<RCTImageURLLoaderWithAttribution>)loadHandler shouldEnablePerfLogging];`
	`914`	`+ return [(id<RCTImageLoaderLoggable>)loadHandler shouldEnablePerfLogging];`
`915`	`915`	`}`
`916`	`916`	`return NO;`
`917`	`917`	`}`