Skip to content

Commit 55f8f3e

Browse files
Martin Konicekfacebook-github-bot-6
authored andcommitted
Explanatory message when starting packager on Windows or unknown platform
Reviewed By: martinbigio Differential Revision: D2564756 fb-gh-sync-id: 097ec541267a54a45d82116a03e4c22b8f49eb99
1 parent afea653 commit 55f8f3e

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

private-cli/src/runAndroid/runAndroid.js

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -132,13 +132,17 @@ function startServerInNewWindow() {
132132
['-e', 'sh', launchPackagerScript],
133133
{detached: true}
134134
);
135+
} else if (/^win/.test(process.platform)) {
136+
console.log(chalk.yellow('Starting the packager in a new window ' +
137+
'is not supported on Windows yet.\nPlease start it manually using ' +
138+
'\'react-native start\'.'));
139+
console.log('We believe the best Windows ' +
140+
'support will come from a community of people\nusing React Native on ' +
141+
'Windows on a daily basis.\n' +
142+
'Would you be up for sending a pull request?');
135143
} else {
136-
console.error(chalk.yellow(
137-
'Starting packager in new window is not supported on Windows yet. ' +
138-
'See https://github.com/facebook/react-native/issues/3469 on how to ' +
139-
'start it manually.'
140-
));
141-
throw new Error('Windows is not yet supported');
144+
console.log(chalk.red('Cannot start the packager. Unknown platform ' +
145+
process.platform));
142146
}
143147
}
144148

0 commit comments

Comments
 (0)