Commit 7b2ee71
Unbreak custom animated components
Summary:
Commit c996081 broke `Animated.createAnimatedComponent()` for most components outside of the standard ones. This is because it will throw an exception for any component without a `viewConfig` defined, which basically no composition style component has AFAIK.
Related issues: #10825, oblador/react-native-vector-icons#337, oblador/react-native-animatable#70
This PR removes the check which is more treating the symptoms really – but shouldn't `setNativeProps` duck typing be enough?
Closes #10827
Differential Revision: D4178183
Pulled By: ericvicenti
fbshipit-source-id: b85cc78ed6d84dada4d476caa243332eaadb003f1 parent 9661d72 commit 7b2ee71
2 files changed
Lines changed: 6 additions & 6 deletions
File tree
- Libraries
- Animated/src
- Renderer/src/renderers/native
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1735 | 1735 | | |
1736 | 1736 | | |
1737 | 1737 | | |
1738 | | - | |
1739 | | - | |
1740 | | - | |
1741 | | - | |
1742 | | - | |
1743 | | - | |
1744 | 1738 | | |
1745 | 1739 | | |
1746 | 1740 | | |
| |||
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
142 | 148 | | |
143 | 149 | | |
144 | 150 | | |
| |||
0 commit comments