Skip to content

Commit 8364c2a

Browse files
cipolleschicortinico
authored andcommitted
Exclude dSYM from the archive (#46472)
Summary: Pull Request resolved: #46472 Currently, we are building the Debug symbols (dSYM) for hermes dSYM but we are not shipping them with the xcframework. This is correct, because Debug symbols can increase the size of Hermes thus enalrging the iOS IPA and increasing the download time when installing pods. We distribute the dSYM separatedly, in case users needs to symbolicate Hermes stack traces. However the path to the dSYM still appears in the Info.plist of the universal XCFramework and this can cause issues when submitting an app to apple. This change should remove those lines from the universal framework. It fixes #35863 [Internal] - Remove dSYM path from Info.plist Reviewed By: cortinico Differential Revision: D62603425 fbshipit-source-id: 038ec3d6b056a3d6f5585c8125d0430f56f11bb9
1 parent 512c939 commit 8364c2a

1 file changed

Lines changed: 0 additions & 12 deletions

File tree

packages/react-native/sdks/hermes-engine/utils/build-apple-framework.sh

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -192,19 +192,7 @@ function create_universal_framework {
192192
for i in "${!platforms[@]}"; do
193193
local platform="${platforms[$i]}"
194194
local hermes_framework_path="${platform}/hermes.framework"
195-
local dSYM_path="$hermes_framework_path"
196-
local dSYM_base_path="$HERMES_PATH/destroot/Library/Frameworks"
197-
198-
# If the dSYM rename has failed, the dSYM are generated as 0.dSYM
199-
# (Apple default name) rather then hermes.framework.dSYM.
200-
if [[ -e "$dSYM_base_path/${platform}/0.dSYM" ]]; then
201-
dSYM_path="${platform}/0"
202-
fi
203-
204195
args+="-framework $hermes_framework_path "
205-
206-
# Path to dSYM must be absolute
207-
args+="-debug-symbols $dSYM_base_path/$dSYM_path.dSYM "
208196
done
209197

210198
mkdir -p universal

0 commit comments

Comments
 (0)