Skip to content

Commit 8e5439f

Browse files
lunaleapsLuna Wei
authored andcommitted
Set hermes for Android template project in testing
Summary: Changelog: [Internal] - Set the hermes value as specified by the test-e2e-local script flag. Right now, the script incorrectly ignores the flag By default, the template project has `hermesEnabled=true` Reviewed By: cipolleschi Differential Revision: D49831355 fbshipit-source-id: 7fb8613fa86f2c6140b7d25b16aeb583e6e26c12
1 parent 3ba5e4f commit 8e5439f

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

scripts/test-e2e-local.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,16 @@ async function testRNTestProject(circleCIArtifacts) {
252252
`echo "react.internal.mavenLocalRepo=${mavenLocalPath}" >> android/gradle.properties`,
253253
);
254254

255+
// Update gradle properties to set Hermes as false
256+
if (!argv.hermes) {
257+
sed(
258+
'-i',
259+
'hermesEnabled=true',
260+
'hermesEnabled=false',
261+
'android/gradle.properties',
262+
);
263+
}
264+
255265
// doing the pod install here so that it's easier to play around RNTestProject
256266
cd('ios');
257267
exec('bundle install');

0 commit comments

Comments
 (0)