Commit 99fb048
Port TextInput-test.js to Fantom and remove the legacy Jest test
Summary:
Migrates the remaining meaningful coverage from `TextInput-test.js` (Jest with snapshots) over to `TextInput-itest.js` (Fantom) so we can rely on a single test file that exercises the real renderer instead of a heavily-mocked one.
Changes in `TextInput-itest.js`:
- Add a `focus()` test verifying that focusing a `TextInput` unfocuses any previously focused one (mirrors Jest's "should unfocus when other TextInput is focused").
- Add a top-level `has the correct displayName` test.
- Add a new set of `props` describes that assert the props from the original Jest snapshot tests reach the mounting layer via `getRenderedOutput({props: [...]}).toJSX()`:
- \`id and nativeID\`: \`id\` → \`nativeID\` mapping, \`nativeID\` pass-through, and \`id\` precedence over \`nativeID\`.
- \`testID\`: pass-through.
- \`aria-label and accessibilityLabel\`: \`aria-label\` → \`accessibilityLabel\` mapping and \`accessibilityLabel\` pass-through.
- \`aria-* and accessibilityState\`: \`aria-busy/checked/disabled/expanded/selected\` mapped into \`accessibilityState\`.
- \`accessibilityRole\`: pass-through.
- \`style\`: \`backgroundColor\` propagated as a native color value.
Tests intentionally NOT ported:
- Inherited \`HostInstance\` method presence checks (\`focus\`, \`blur\`, \`setNativeProps\`, \`measure\`, \`measureInWindow\`, \`measureLayout\`): they are guaranteed by Flow typing on \`ReactNativeElement\`, exercised in \`ReactNativeElement-itest.js\`, and Flow's \`method-unbinding\` rule prevents the simple \`toBeInstanceOf(Function)\` check without \`\$FlowFixMe\` (which is forbidden by project rules).
- \`focus() should not do anything if the TextInput is not editable\`: \`TextInputState.focusTextInput\` reads \`textField.currentProps?.editable\`, but in the new architecture \`currentProps\` is not exposed on the public \`ReactNativeElement\` instance, so the check is effectively bypassed. The Jest test only passed by monkey-patching \`currentProps\`. Documenting this as expected behavior in Fantom would mask a real bug.
- \`should give precedence to textContentType when set\`: \`textContentType\` is iOS-only and Fantom defaults to Android (\`AndroidTextInput\`).
Files removed:
- \`Libraries/Components/TextInput/__tests__/TextInput-test.js\`
- \`Libraries/Components/TextInput/__tests__/__snapshots__/TextInput-test.js.snap\`
Changelog: [Internal]
Differential Revision: D1019772251 parent 42349ca commit 99fb048
3 files changed
Lines changed: 173 additions & 673 deletions
File tree
- packages/react-native/Libraries/Components/TextInput/__tests__
- __snapshots__
Lines changed: 173 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
148 | 148 | | |
149 | 149 | | |
150 | 150 | | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
151 | 283 | | |
152 | 284 | | |
153 | 285 | | |
| |||
276 | 408 | | |
277 | 409 | | |
278 | 410 | | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
279 | 448 | | |
280 | 449 | | |
281 | 450 | | |
| |||
459 | 628 | | |
460 | 629 | | |
461 | 630 | | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
462 | 635 | | |
0 commit comments