Skip to content

Commit a02052d

Browse files
mdvaccafacebook-github-bot
authored andcommitted
Mark BridgelessCatalystInstance as LegacyArchitecture and remove DoNotStrip (#51111)
Summary: Pull Request resolved: #51111 BridgelessCatalystInstance is unused in bridgeless, any usage will lead to an exception / crash. This diffs marks BridgelessCatalystInstance as LegacyArchitecture and removes DoNotStrip annotation to enable further optimizations changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D74200097 fbshipit-source-id: f99b6fa74c30bdf0e1cd6758e223601b3ce5826c
1 parent e69e35e commit a02052d

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/BridgelessCatalystInstance.kt

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
package com.facebook.react.runtime
1313

1414
import android.content.res.AssetManager
15-
import com.facebook.proguard.annotations.DoNotStrip
1615
import com.facebook.react.bridge.CatalystInstance
1716
import com.facebook.react.bridge.JavaScriptContextHolder
1817
import com.facebook.react.bridge.JavaScriptModule
@@ -26,14 +25,16 @@ import com.facebook.react.bridge.RuntimeScheduler
2625
import com.facebook.react.bridge.UIManager
2726
import com.facebook.react.bridge.queue.ReactQueueConfiguration
2827
import com.facebook.react.common.annotations.VisibleForTesting
28+
import com.facebook.react.common.annotations.internal.LegacyArchitecture
29+
import com.facebook.react.common.annotations.internal.LegacyArchitectureLogger
2930
import com.facebook.react.internal.turbomodule.core.interfaces.TurboModuleRegistry
3031
import com.facebook.react.turbomodule.core.interfaces.CallInvokerHolder
3132
import com.facebook.react.turbomodule.core.interfaces.NativeMethodCallInvokerHolder
3233

33-
@DoNotStrip
3434
@Deprecated(
3535
message =
3636
"This class is deprecated, please to migrate to new architecture using [com.facebook.react.defaults.DefaultReactHost] instead.")
37+
@LegacyArchitecture
3738
internal class BridgelessCatalystInstance(private val reactHost: ReactHostImpl) : CatalystInstance {
3839

3940
override fun handleMemoryPressure(level: Int) {
@@ -68,7 +69,6 @@ internal class BridgelessCatalystInstance(private val reactHost: ReactHostImpl)
6869
throw UnsupportedOperationException("Unimplemented method 'hasRunJSBundle'")
6970
}
7071

71-
@DoNotStrip
7272
override fun invokeCallback(callbackID: Int, arguments: NativeArrayInterface) {
7373
throw UnsupportedOperationException("Unimplemented method 'invokeCallback'")
7474
}
@@ -172,4 +172,10 @@ internal class BridgelessCatalystInstance(private val reactHost: ReactHostImpl)
172172
override fun getFabricUIManager(): UIManager {
173173
throw UnsupportedOperationException("Unimplemented method 'getFabricUIManager'")
174174
}
175+
176+
private companion object {
177+
init {
178+
LegacyArchitectureLogger.assertLegacyArchitecture("BridgelessCatalystInstance")
179+
}
180+
}
175181
}

0 commit comments

Comments
 (0)