Use artifacts published from the Hermes repository on iOS (#53653)

Summary:

Changelog: [IOS][CHANGED] - Changed the coordinates of hermes artifacts to those published from the Hermes repository regardless of which version is used

Differential Revision: D81770379

Author: j-piasecki

packages/react-native/sdks/hermes-engine/hermes-engine.podspec

@@ -20,7 +20,7 @@ end
 
 # package.json
 package = JSON.parse(File.read(File.join(react_native_path, "package.json")))
-# TODO: T231755000 use the Hermes V1 version instead of React Native version
+# TODO: T231755000 use the Hermes version instead of React Native version
 version = package['version']
 
 source_type = hermes_source_type(version, react_native_path)
@@ -64,9 +64,8 @@ Pod::Spec.new do |spec|
     end
 
     # When using the local prebuilt tarball, it should include hermesc compatible with the used VM.
-    # In other cases, when using Hermes V1, the prebuilt versioned binaries can be used.
-    # TODO: T236142916 hermesc should be consumed from NPM even when not using Hermes V1
-    if source_type != HermesEngineSourceType::LOCAL_PREBUILT_TARBALL && ENV['RCT_HERMES_V1_ENABLED'] == "1"
+    # In other cases, the prebuilt versioned binaries can be used.
+    if source_type != HermesEngineSourceType::LOCAL_PREBUILT_TARBALL
       hermes_compiler_path = File.dirname(Pod::Executable.execute_command('node', ['-p',
         'require.resolve(
         "hermes-compiler",

packages/react-native/sdks/hermes-engine/hermes-utils.rb

@@ -224,18 +224,11 @@ def release_tarball_url(version, build_type)
         ENV['ENTERPRISE_REPOSITORY'] != nil && ENV['ENTERPRISE_REPOSITORY'] != "" ?
         ENV['ENTERPRISE_REPOSITORY'] :
         "https://repo1.maven.org/maven2"
+    namespace = "com/facebook/hermes"
 
-    if hermes_v1_enabled()
-        namespace = "com/facebook/hermes"
-        # Sample url from Maven:
-        # https://repo1.maven.org/maven2/com/facebook/hermes/hermes-ios/0.14.0/hermes-ios-0.14.0-debug.tar.gz
-        return "#{maven_repo_url}/#{namespace}/hermes-ios/#{version}/hermes-ios-#{version}-#{build_type.to_s}.tar.gz"
-    else
-        namespace = "com/facebook/react"
-        # Sample url from Maven:
-        # https://repo1.maven.org/maven2/com/facebook/react/react-native-artifacts/0.71.0/react-native-artifacts-0.71.0-hermes-ios-debug.tar.gz
-        return "#{maven_repo_url}/#{namespace}/react-native-artifacts/#{version}/react-native-artifacts-#{version}-hermes-ios-#{build_type.to_s}.tar.gz"
-    end
+    # Sample url from Maven:
+    # https://repo1.maven.org/maven2/com/facebook/hermes/hermes-ios/0.14.0/hermes-ios-0.14.0-debug.tar.gz
+    return "#{maven_repo_url}/#{namespace}/hermes-ios/#{version}/hermes-ios-#{version}-#{build_type.to_s}.tar.gz"
 end
 
 def download_stable_hermes(react_native_path, version, configuration)
@@ -257,16 +250,9 @@ def download_hermes_tarball(react_native_path, tarball_url, version, configurati
 end
 
 def nightly_tarball_url(version)
-  # TODO: T231755027 update coordinates and versioning
-  artifact_coordinate = "react-native-artifacts"
+  artifact_coordinate = "hermes-ios"
   artifact_name = "hermes-ios-debug.tar.gz"
-  namespace = "com/facebook/react"
-
-  if hermes_v1_enabled()
-    artifact_coordinate = "hermes-ios"
-    artifact_name = "hermes-ios-debug.tar.gz"
-    namespace = "com/facebook/hermes"
-  end
+  namespace = "com/facebook/hermes"
 
   xml_url = "https://central.sonatype.com/repository/maven-snapshots/#{namespace}/#{artifact_coordinate}/#{version}-SNAPSHOT/maven-metadata.xml"
 

scripts/releases/set-rn-artifacts-version.js

@@ -155,7 +155,7 @@ function updateTestFiles(
 async function updateGradleFile(version /*: string */) /*: Promise<void> */ {
   const contents = await fs.readFile(GRADLE_FILE_PATH, 'utf-8');
 
-  // TODO: T231755027 set HERMES_VERSION_NAME
+  // TODO: T231755027 set HERMES_VERSION_NAME and HERMES_V1_VERSION_NAME
 
   return fs.writeFile(
     GRADLE_FILE_PATH,