-
Notifications
You must be signed in to change notification settings - Fork 10
Open
Description
Optimization
- reuse common bundles, such as
react,react-dom,draft-js,lodash,immutable, .etc, large bundles. - lazy load optional webpack bundles, such as
draft-js(more than 150kb) - do not load unnecessary bundles(因為我們目前 bundles 產生是透過
packages/embed-code-generator,它的 main bundle 會有feeback,qa-list和questionnaire的程式碼,但使用者可能只需要feedback的 embed code ) - 把 bundles/chunks 上傳到我們的 CDN,而非透過 unpkg 來提供檔案;原因在於 unpkg 的網址包含 pkg version,不利於 CDN cache,只要我們一升版,網址改變,所有的 cache 都需要重來一遍。
Code Refactoring
- make all codes pass eslint and prettier
- add prettier, eslint commit hook
- extract
packages/questionnaire/src/react-components/draftto be an pkg (readr-media/draft-editor) underpackages/draft-editor
Infrustructure
- add CI to build and publish sub pkgs to npm registry, such as
@readr-media/react-feedbackif there are new commits in the repo. - automatically upgrade
@readr-media/react-embed-code-generatorpkg if there is any sub pkg (@readr-media/react-feedback,@readr-media/react-qa-list,@readr-media/react-questionnaire) upgraded. - automatically upgrade
@readr-media/questionnaireand@readr-media/react-qa-listpkg if@readr-media/draft-editoris upgraded.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels