From 21383c0ee1aeec14baa520da49b1ab665e0dfcd5 Mon Sep 17 00:00:00 2001 From: "jesse.berger" Date: Wed, 4 Mar 2026 15:44:24 +0100 Subject: [PATCH 1/4] RT-17796 Added Metadata fields --- src/Domain/TLDMetaData.php | 52 ++++++++++++++++++- .../metadata/metadata_unknown_feature.php | 8 +++ tests/Domain/data/metadata/metadata_valid.php | 8 +++ tests/Domain/data/tldinfo.php | 8 +++ tests/Domain/data/tldinfo_com.json | 10 +++- tests/Domain/data/tldinfo_nl.json | 10 +++- 6 files changed, 92 insertions(+), 4 deletions(-) diff --git a/src/Domain/TLDMetaData.php b/src/Domain/TLDMetaData.php index 7a324b4..2d8c859 100644 --- a/src/Domain/TLDMetaData.php +++ b/src/Domain/TLDMetaData.php @@ -50,6 +50,14 @@ final class TLDMetaData implements DomainObjectInterface public bool $creationRequiresPreValidation; + public bool $createDomainRequiresValidation; + + public bool $transferDomainIncomingRequiresValidation; + + public bool $transferDomainInternalRequiresValidation; + + public bool $updateDomainRequiresValidation; + public ?string $zoneCheck; public ?array $possibleClientDomainStatuses; @@ -94,6 +102,14 @@ final class TLDMetaData implements DomainObjectInterface public ?LaunchPhaseCollection $launchPhases; + public ?string $kbLink; + + public bool $wdrpNotifications; + + public bool $errpNotifications; + + public ?int $daysTransferLock; + private function __construct( array $createDomainPeriods, array $renewDomainPeriods, @@ -104,6 +120,10 @@ private function __construct( bool $transferSupportsAuthcode, bool $transferRequiresAuthcode, bool $creationRequiresPreValidation, + bool $createDomainRequiresValidation, + bool $transferDomainIncomingRequiresValidation, + bool $transferDomainInternalRequiresValidation, + bool $updateDomainRequiresValidation, array $featuresAvailable, bool $registrantChangeApprovalRequired, string $whoisExposure, @@ -133,7 +153,11 @@ private function __construct( ?string $jurisdiction, ?string $termsOfService, ?string $privacyPolicy, - string $premiumSupport + string $premiumSupport, + ?string $kbLink, + bool $wdrpNotifications, + bool $errpNotifications, + ?int $daysTransferLock ) { $this->createDomainPeriods = $createDomainPeriods; $this->renewDomainPeriods = $renewDomainPeriods; @@ -144,6 +168,10 @@ private function __construct( $this->transferSupportsAuthcode = $transferSupportsAuthcode; $this->transferRequiresAuthcode = $transferRequiresAuthcode; $this->creationRequiresPreValidation = $creationRequiresPreValidation; + $this->createDomainRequiresValidation = $createDomainRequiresValidation; + $this->transferDomainIncomingRequiresValidation = $transferDomainIncomingRequiresValidation; + $this->transferDomainInternalRequiresValidation = $transferDomainInternalRequiresValidation; + $this->updateDomainRequiresValidation = $updateDomainRequiresValidation; $this->featuresAvailable = $featuresAvailable; $this->registrantChangeApprovalRequired = $registrantChangeApprovalRequired; $this->whoisExposure = $whoisExposure; @@ -174,6 +202,10 @@ private function __construct( $this->termsOfService = $termsOfService; $this->privacyPolicy = $privacyPolicy; $this->premiumSupport = $premiumSupport; + $this->kbLink = $kbLink; + $this->wdrpNotifications = $wdrpNotifications; + $this->errpNotifications = $errpNotifications; + $this->daysTransferLock = $daysTransferLock; } public static function fromArray(array $json): TLDMetaData @@ -204,6 +236,10 @@ public static function fromArray(array $json): TLDMetaData $json['transferSupportsAuthcode'], $json['transferRequiresAuthcode'], $json['creationRequiresPreValidation'], + $json['createDomainRequiresValidation'], + $json['transferDomainIncomingRequiresValidation'], + $json['transferDomainInternalRequiresValidation'], + $json['updateDomainRequiresValidation'], $json['featuresAvailable'], $json['registrantChangeApprovalRequired'], $json['whoisExposure'], @@ -233,7 +269,11 @@ public static function fromArray(array $json): TLDMetaData $json['jurisdiction'] ?? null, $json['termsOfService'] ?? null, $json['privacyPolicy'] ?? null, - $json['premiumSupport'] + $json['premiumSupport'], + $json['kbLink'], + $json['wdrpNotifications'], + $json['errpNotifications'], + $json['daysTransferLock'] ); } @@ -257,6 +297,10 @@ public function toArray(): array 'transferSupportsAuthcode' => $this->transferSupportsAuthcode, 'transferRequiresAuthcode' => $this->transferRequiresAuthcode, 'creationRequiresPreValidation' => $this->creationRequiresPreValidation, + 'createDomainRequiresValidation' => $this->createDomainRequiresValidation, + 'transferDomainIncomingRequiresValidation' => $this->transferDomainIncomingRequiresValidation, + 'transferDomainInternalRequiresValidation' => $this->transferDomainInternalRequiresValidation, + 'updateDomainRequiresValidation' => $this->updateDomainRequiresValidation, 'zoneCheck' => $this->zoneCheck, 'possibleClientDomainStatuses' => $this->possibleClientDomainStatuses, 'allowedDnssecRecords' => $this->allowedDnssecRecords, @@ -271,6 +315,10 @@ public function toArray(): array 'whoisExposure' => $this->whoisExposure, 'gdprCategory' => $this->gdprCategory, 'premiumSupport' => $this->premiumSupport, + 'kbLink' => $this->kbLink, + 'wdrpNotifications' => $this->wdrpNotifications, + 'errpNotifications' => $this->errpNotifications, + 'daysTransferLock' => $this->daysTransferLock, 'domainSyntax' => $this->domainSyntax->toArray(), 'nameservers' => $this->nameservers->toArray(), 'registrant' => $this->registrant->toArray(), diff --git a/tests/Domain/data/metadata/metadata_unknown_feature.php b/tests/Domain/data/metadata/metadata_unknown_feature.php index 884f0ac..ceee085 100644 --- a/tests/Domain/data/metadata/metadata_unknown_feature.php +++ b/tests/Domain/data/metadata/metadata_unknown_feature.php @@ -18,11 +18,19 @@ 'transferSupportsAuthcode' => false, 'transferRequiresAuthcode' => false, 'creationRequiresPreValidation' => false, + 'createDomainRequiresValidation' => false, + 'transferDomainIncomingRequiresValidation' => false, + 'transferDomainInternalRequiresValidation' => false, + 'updateDomainRequiresValidation' => false, 'featuresAvailable' => ['CREATE', 'RENEW', 'REVIVE'], 'registrantChangeApprovalRequired' => false, 'whoisExposure' => '', 'gdprCategory' => '', 'premiumSupport' => 'REGULAR', + 'kbLink' => 'https://kb.realtimeregister.com/article/469-abuse-reports-or-legal-inquiries', + 'wdrpNotifications' => false, + 'errpNotifications' => false, + 'daysTransferLock' => 0, 'domainSyntax' => ['minLength' => 1, 'maxLength' => 64, 'idnSupport' => false], // DomainSyntax 'nameservers' => ['min' => 0, 'max' => 13, 'required' => false], // Nameservers 'registrant' => [ 'organizationRequired' => false, 'organizationAllowed' => true], // Registrant diff --git a/tests/Domain/data/metadata/metadata_valid.php b/tests/Domain/data/metadata/metadata_valid.php index 87a616d..2c58eda 100644 --- a/tests/Domain/data/metadata/metadata_valid.php +++ b/tests/Domain/data/metadata/metadata_valid.php @@ -18,11 +18,19 @@ 'transferSupportsAuthcode' => false, 'transferRequiresAuthcode' => false, 'creationRequiresPreValidation' => false, + 'createDomainRequiresValidation' => false, + 'transferDomainIncomingRequiresValidation' => false, + 'transferDomainInternalRequiresValidation' => false, + 'updateDomainRequiresValidation' => false, 'featuresAvailable' => ['CREATE', 'RENEW'], 'registrantChangeApprovalRequired' => false, 'whoisExposure' => 'FULL', 'gdprCategory' => 'EU_BASED', 'premiumSupport' => 'REGULAR', + 'kbLink' => 'https://kb.realtimeregister.com/article/469-abuse-reports-or-legal-inquiries', + 'wdrpNotifications' => false, + 'errpNotifications' => false, + 'daysTransferLock' => 0, 'domainSyntax' => ['minLength' => 1, 'maxLength' => 64, 'idnSupport' => false], // DomainSyntax 'nameservers' => ['min' => 0, 'max' => 13, 'required' => false], // Nameservers 'registrant' => [ 'organizationRequired' => false, 'organizationAllowed' => true], // Registrant diff --git a/tests/Domain/data/tldinfo.php b/tests/Domain/data/tldinfo.php index c6cf850..783d9ed 100644 --- a/tests/Domain/data/tldinfo.php +++ b/tests/Domain/data/tldinfo.php @@ -21,6 +21,10 @@ 'transferSupportsAuthcode' => true, 'transferRequiresAuthcode' => true, 'creationRequiresPreValidation' => true, + 'createDomainRequiresValidation' => false, + 'transferDomainIncomingRequiresValidation' => false, + 'transferDomainInternalRequiresValidation' => false, + 'updateDomainRequiresValidation' => false, 'zoneCheck' => 'True', 'possibleClientDomainStatuses' => [ 'CLIENT_HOLD', @@ -50,6 +54,10 @@ 'whoisExposure' => 'NONE', 'gdprCategory' => 'EU_BASED', 'premiumSupport' => 'REGULAR', + 'kbLink' => 'https://kb.realtimeregister.com/article/469-abuse-reports-or-legal-inquiries', + 'wdrpNotifications' => false, + 'errpNotifications' => false, + 'daysTransferLock' => 0, 'domainSyntax' => include __DIR__ . '/domains/domain_syntax.php', 'nameservers' => include __DIR__ . '/nameservers.php', 'registrant' => include __DIR__ . '/registrant.php', diff --git a/tests/Domain/data/tldinfo_com.json b/tests/Domain/data/tldinfo_com.json index ef7d95c..4ffc222 100644 --- a/tests/Domain/data/tldinfo_com.json +++ b/tests/Domain/data/tldinfo_com.json @@ -42,6 +42,10 @@ "renewGracePeriod": 5, "transferGracePeriod": 5, "creationRequiresPreValidation": false, + "createDomainRequiresValidation": false, + "transferDomainIncomingRequiresValidation": false, + "transferDomainInternalRequiresValidation": false, + "updateDomainRequiresValidation": false, "transferFOA": true, "featuresAvailable": [ "RESTORE", @@ -463,7 +467,11 @@ "premiumSupport": "NO", "registrantChangeApprovalRequired": true, "allowDesignatedAgent": "BOTH", - "validationCategory": "General" + "validationCategory": "General", + "kbLink": "https://kb.realtimeregister.com/article/469-abuse-reports-or-legal-inquiries", + "wdrpNotifications": false, + "errpNotifications": false, + "daysTransferLock": 0 }, "provider": "Verisign", "applicableFor": [ diff --git a/tests/Domain/data/tldinfo_nl.json b/tests/Domain/data/tldinfo_nl.json index 8ebe8ec..71eb9ef 100644 --- a/tests/Domain/data/tldinfo_nl.json +++ b/tests/Domain/data/tldinfo_nl.json @@ -107,6 +107,10 @@ "registrantChangeApprovalRequired": false, "redemptionPeriod": 40, "creationRequiresPreValidation": false, + "createDomainRequiresValidation": false, + "transferDomainIncomingRequiresValidation": false, + "transferDomainInternalRequiresValidation": false, + "updateDomainRequiresValidation": false, "transferFOA": false, "featuresAvailable": [ "CREATE", @@ -122,7 +126,11 @@ "registrant": { "organizationRequired": false, "organizationAllowed": true - } + }, + "kbLink": "https://kb.realtimeregister.com/article/469-abuse-reports-or-legal-inquiries", + "wdrpNotifications": false, + "errpNotifications": false, + "daysTransferLock": 0 }, "provider": "Sidn", "applicableFor": [ From bbae928d91db1d05b7209f49da67e2c5fee03bc3 Mon Sep 17 00:00:00 2001 From: "jesse.berger" Date: Wed, 8 Apr 2026 11:51:51 +0200 Subject: [PATCH 2/4] RT-17796 Review comments --- src/Domain/TLDMetaData.php | 30 ------------------- .../metadata/metadata_unknown_feature.php | 5 ---- tests/Domain/data/metadata/metadata_valid.php | 5 ---- tests/Domain/data/tldinfo.php | 5 ---- tests/Domain/data/tldinfo_com.json | 5 ---- tests/Domain/data/tldinfo_nl.json | 5 ---- 6 files changed, 55 deletions(-) diff --git a/src/Domain/TLDMetaData.php b/src/Domain/TLDMetaData.php index 2d8c859..77fc907 100644 --- a/src/Domain/TLDMetaData.php +++ b/src/Domain/TLDMetaData.php @@ -50,14 +50,6 @@ final class TLDMetaData implements DomainObjectInterface public bool $creationRequiresPreValidation; - public bool $createDomainRequiresValidation; - - public bool $transferDomainIncomingRequiresValidation; - - public bool $transferDomainInternalRequiresValidation; - - public bool $updateDomainRequiresValidation; - public ?string $zoneCheck; public ?array $possibleClientDomainStatuses; @@ -102,8 +94,6 @@ final class TLDMetaData implements DomainObjectInterface public ?LaunchPhaseCollection $launchPhases; - public ?string $kbLink; - public bool $wdrpNotifications; public bool $errpNotifications; @@ -120,10 +110,6 @@ private function __construct( bool $transferSupportsAuthcode, bool $transferRequiresAuthcode, bool $creationRequiresPreValidation, - bool $createDomainRequiresValidation, - bool $transferDomainIncomingRequiresValidation, - bool $transferDomainInternalRequiresValidation, - bool $updateDomainRequiresValidation, array $featuresAvailable, bool $registrantChangeApprovalRequired, string $whoisExposure, @@ -154,7 +140,6 @@ private function __construct( ?string $termsOfService, ?string $privacyPolicy, string $premiumSupport, - ?string $kbLink, bool $wdrpNotifications, bool $errpNotifications, ?int $daysTransferLock @@ -168,10 +153,6 @@ private function __construct( $this->transferSupportsAuthcode = $transferSupportsAuthcode; $this->transferRequiresAuthcode = $transferRequiresAuthcode; $this->creationRequiresPreValidation = $creationRequiresPreValidation; - $this->createDomainRequiresValidation = $createDomainRequiresValidation; - $this->transferDomainIncomingRequiresValidation = $transferDomainIncomingRequiresValidation; - $this->transferDomainInternalRequiresValidation = $transferDomainInternalRequiresValidation; - $this->updateDomainRequiresValidation = $updateDomainRequiresValidation; $this->featuresAvailable = $featuresAvailable; $this->registrantChangeApprovalRequired = $registrantChangeApprovalRequired; $this->whoisExposure = $whoisExposure; @@ -202,7 +183,6 @@ private function __construct( $this->termsOfService = $termsOfService; $this->privacyPolicy = $privacyPolicy; $this->premiumSupport = $premiumSupport; - $this->kbLink = $kbLink; $this->wdrpNotifications = $wdrpNotifications; $this->errpNotifications = $errpNotifications; $this->daysTransferLock = $daysTransferLock; @@ -236,10 +216,6 @@ public static function fromArray(array $json): TLDMetaData $json['transferSupportsAuthcode'], $json['transferRequiresAuthcode'], $json['creationRequiresPreValidation'], - $json['createDomainRequiresValidation'], - $json['transferDomainIncomingRequiresValidation'], - $json['transferDomainInternalRequiresValidation'], - $json['updateDomainRequiresValidation'], $json['featuresAvailable'], $json['registrantChangeApprovalRequired'], $json['whoisExposure'], @@ -270,7 +246,6 @@ public static function fromArray(array $json): TLDMetaData $json['termsOfService'] ?? null, $json['privacyPolicy'] ?? null, $json['premiumSupport'], - $json['kbLink'], $json['wdrpNotifications'], $json['errpNotifications'], $json['daysTransferLock'] @@ -297,10 +272,6 @@ public function toArray(): array 'transferSupportsAuthcode' => $this->transferSupportsAuthcode, 'transferRequiresAuthcode' => $this->transferRequiresAuthcode, 'creationRequiresPreValidation' => $this->creationRequiresPreValidation, - 'createDomainRequiresValidation' => $this->createDomainRequiresValidation, - 'transferDomainIncomingRequiresValidation' => $this->transferDomainIncomingRequiresValidation, - 'transferDomainInternalRequiresValidation' => $this->transferDomainInternalRequiresValidation, - 'updateDomainRequiresValidation' => $this->updateDomainRequiresValidation, 'zoneCheck' => $this->zoneCheck, 'possibleClientDomainStatuses' => $this->possibleClientDomainStatuses, 'allowedDnssecRecords' => $this->allowedDnssecRecords, @@ -315,7 +286,6 @@ public function toArray(): array 'whoisExposure' => $this->whoisExposure, 'gdprCategory' => $this->gdprCategory, 'premiumSupport' => $this->premiumSupport, - 'kbLink' => $this->kbLink, 'wdrpNotifications' => $this->wdrpNotifications, 'errpNotifications' => $this->errpNotifications, 'daysTransferLock' => $this->daysTransferLock, diff --git a/tests/Domain/data/metadata/metadata_unknown_feature.php b/tests/Domain/data/metadata/metadata_unknown_feature.php index ceee085..ccf81b2 100644 --- a/tests/Domain/data/metadata/metadata_unknown_feature.php +++ b/tests/Domain/data/metadata/metadata_unknown_feature.php @@ -18,16 +18,11 @@ 'transferSupportsAuthcode' => false, 'transferRequiresAuthcode' => false, 'creationRequiresPreValidation' => false, - 'createDomainRequiresValidation' => false, - 'transferDomainIncomingRequiresValidation' => false, - 'transferDomainInternalRequiresValidation' => false, - 'updateDomainRequiresValidation' => false, 'featuresAvailable' => ['CREATE', 'RENEW', 'REVIVE'], 'registrantChangeApprovalRequired' => false, 'whoisExposure' => '', 'gdprCategory' => '', 'premiumSupport' => 'REGULAR', - 'kbLink' => 'https://kb.realtimeregister.com/article/469-abuse-reports-or-legal-inquiries', 'wdrpNotifications' => false, 'errpNotifications' => false, 'daysTransferLock' => 0, diff --git a/tests/Domain/data/metadata/metadata_valid.php b/tests/Domain/data/metadata/metadata_valid.php index 2c58eda..b8eabc2 100644 --- a/tests/Domain/data/metadata/metadata_valid.php +++ b/tests/Domain/data/metadata/metadata_valid.php @@ -18,16 +18,11 @@ 'transferSupportsAuthcode' => false, 'transferRequiresAuthcode' => false, 'creationRequiresPreValidation' => false, - 'createDomainRequiresValidation' => false, - 'transferDomainIncomingRequiresValidation' => false, - 'transferDomainInternalRequiresValidation' => false, - 'updateDomainRequiresValidation' => false, 'featuresAvailable' => ['CREATE', 'RENEW'], 'registrantChangeApprovalRequired' => false, 'whoisExposure' => 'FULL', 'gdprCategory' => 'EU_BASED', 'premiumSupport' => 'REGULAR', - 'kbLink' => 'https://kb.realtimeregister.com/article/469-abuse-reports-or-legal-inquiries', 'wdrpNotifications' => false, 'errpNotifications' => false, 'daysTransferLock' => 0, diff --git a/tests/Domain/data/tldinfo.php b/tests/Domain/data/tldinfo.php index 783d9ed..ac4cf67 100644 --- a/tests/Domain/data/tldinfo.php +++ b/tests/Domain/data/tldinfo.php @@ -21,10 +21,6 @@ 'transferSupportsAuthcode' => true, 'transferRequiresAuthcode' => true, 'creationRequiresPreValidation' => true, - 'createDomainRequiresValidation' => false, - 'transferDomainIncomingRequiresValidation' => false, - 'transferDomainInternalRequiresValidation' => false, - 'updateDomainRequiresValidation' => false, 'zoneCheck' => 'True', 'possibleClientDomainStatuses' => [ 'CLIENT_HOLD', @@ -54,7 +50,6 @@ 'whoisExposure' => 'NONE', 'gdprCategory' => 'EU_BASED', 'premiumSupport' => 'REGULAR', - 'kbLink' => 'https://kb.realtimeregister.com/article/469-abuse-reports-or-legal-inquiries', 'wdrpNotifications' => false, 'errpNotifications' => false, 'daysTransferLock' => 0, diff --git a/tests/Domain/data/tldinfo_com.json b/tests/Domain/data/tldinfo_com.json index 4ffc222..6793f0e 100644 --- a/tests/Domain/data/tldinfo_com.json +++ b/tests/Domain/data/tldinfo_com.json @@ -42,10 +42,6 @@ "renewGracePeriod": 5, "transferGracePeriod": 5, "creationRequiresPreValidation": false, - "createDomainRequiresValidation": false, - "transferDomainIncomingRequiresValidation": false, - "transferDomainInternalRequiresValidation": false, - "updateDomainRequiresValidation": false, "transferFOA": true, "featuresAvailable": [ "RESTORE", @@ -468,7 +464,6 @@ "registrantChangeApprovalRequired": true, "allowDesignatedAgent": "BOTH", "validationCategory": "General", - "kbLink": "https://kb.realtimeregister.com/article/469-abuse-reports-or-legal-inquiries", "wdrpNotifications": false, "errpNotifications": false, "daysTransferLock": 0 diff --git a/tests/Domain/data/tldinfo_nl.json b/tests/Domain/data/tldinfo_nl.json index 71eb9ef..18846a3 100644 --- a/tests/Domain/data/tldinfo_nl.json +++ b/tests/Domain/data/tldinfo_nl.json @@ -107,10 +107,6 @@ "registrantChangeApprovalRequired": false, "redemptionPeriod": 40, "creationRequiresPreValidation": false, - "createDomainRequiresValidation": false, - "transferDomainIncomingRequiresValidation": false, - "transferDomainInternalRequiresValidation": false, - "updateDomainRequiresValidation": false, "transferFOA": false, "featuresAvailable": [ "CREATE", @@ -127,7 +123,6 @@ "organizationRequired": false, "organizationAllowed": true }, - "kbLink": "https://kb.realtimeregister.com/article/469-abuse-reports-or-legal-inquiries", "wdrpNotifications": false, "errpNotifications": false, "daysTransferLock": 0 From 56330e945ab7f62ae98904acf3a01d478eeca5ff Mon Sep 17 00:00:00 2001 From: "jesse.berger" Date: Mon, 13 Apr 2026 10:20:46 +0200 Subject: [PATCH 3/4] RT-17796 Name change to transferLockDays --- src/Domain/TLDMetaData.php | 10 +++++----- .../Domain/data/metadata/metadata_unknown_feature.php | 2 +- tests/Domain/data/metadata/metadata_valid.php | 2 +- tests/Domain/data/tldinfo.php | 2 +- tests/Domain/data/tldinfo_com.json | 2 +- tests/Domain/data/tldinfo_nl.json | 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/Domain/TLDMetaData.php b/src/Domain/TLDMetaData.php index 77fc907..968bb2e 100644 --- a/src/Domain/TLDMetaData.php +++ b/src/Domain/TLDMetaData.php @@ -98,7 +98,7 @@ final class TLDMetaData implements DomainObjectInterface public bool $errpNotifications; - public ?int $daysTransferLock; + public ?int $transferLockDays; private function __construct( array $createDomainPeriods, @@ -142,7 +142,7 @@ private function __construct( string $premiumSupport, bool $wdrpNotifications, bool $errpNotifications, - ?int $daysTransferLock + ?int $transferLockDays ) { $this->createDomainPeriods = $createDomainPeriods; $this->renewDomainPeriods = $renewDomainPeriods; @@ -185,7 +185,7 @@ private function __construct( $this->premiumSupport = $premiumSupport; $this->wdrpNotifications = $wdrpNotifications; $this->errpNotifications = $errpNotifications; - $this->daysTransferLock = $daysTransferLock; + $this->transferLockDays = $transferLockDays; } public static function fromArray(array $json): TLDMetaData @@ -248,7 +248,7 @@ public static function fromArray(array $json): TLDMetaData $json['premiumSupport'], $json['wdrpNotifications'], $json['errpNotifications'], - $json['daysTransferLock'] + $json['transferLockDays'] ); } @@ -288,7 +288,7 @@ public function toArray(): array 'premiumSupport' => $this->premiumSupport, 'wdrpNotifications' => $this->wdrpNotifications, 'errpNotifications' => $this->errpNotifications, - 'daysTransferLock' => $this->daysTransferLock, + 'transferLockDays' => $this->transferLockDays, 'domainSyntax' => $this->domainSyntax->toArray(), 'nameservers' => $this->nameservers->toArray(), 'registrant' => $this->registrant->toArray(), diff --git a/tests/Domain/data/metadata/metadata_unknown_feature.php b/tests/Domain/data/metadata/metadata_unknown_feature.php index ccf81b2..9e7e1db 100644 --- a/tests/Domain/data/metadata/metadata_unknown_feature.php +++ b/tests/Domain/data/metadata/metadata_unknown_feature.php @@ -25,7 +25,7 @@ 'premiumSupport' => 'REGULAR', 'wdrpNotifications' => false, 'errpNotifications' => false, - 'daysTransferLock' => 0, + 'transferLockDays' => 0, 'domainSyntax' => ['minLength' => 1, 'maxLength' => 64, 'idnSupport' => false], // DomainSyntax 'nameservers' => ['min' => 0, 'max' => 13, 'required' => false], // Nameservers 'registrant' => [ 'organizationRequired' => false, 'organizationAllowed' => true], // Registrant diff --git a/tests/Domain/data/metadata/metadata_valid.php b/tests/Domain/data/metadata/metadata_valid.php index b8eabc2..ce7342e 100644 --- a/tests/Domain/data/metadata/metadata_valid.php +++ b/tests/Domain/data/metadata/metadata_valid.php @@ -25,7 +25,7 @@ 'premiumSupport' => 'REGULAR', 'wdrpNotifications' => false, 'errpNotifications' => false, - 'daysTransferLock' => 0, + 'transferLockDays' => 0, 'domainSyntax' => ['minLength' => 1, 'maxLength' => 64, 'idnSupport' => false], // DomainSyntax 'nameservers' => ['min' => 0, 'max' => 13, 'required' => false], // Nameservers 'registrant' => [ 'organizationRequired' => false, 'organizationAllowed' => true], // Registrant diff --git a/tests/Domain/data/tldinfo.php b/tests/Domain/data/tldinfo.php index ac4cf67..fc6f08b 100644 --- a/tests/Domain/data/tldinfo.php +++ b/tests/Domain/data/tldinfo.php @@ -52,7 +52,7 @@ 'premiumSupport' => 'REGULAR', 'wdrpNotifications' => false, 'errpNotifications' => false, - 'daysTransferLock' => 0, + 'transferLockDays' => 0, 'domainSyntax' => include __DIR__ . '/domains/domain_syntax.php', 'nameservers' => include __DIR__ . '/nameservers.php', 'registrant' => include __DIR__ . '/registrant.php', diff --git a/tests/Domain/data/tldinfo_com.json b/tests/Domain/data/tldinfo_com.json index 6793f0e..9c1b026 100644 --- a/tests/Domain/data/tldinfo_com.json +++ b/tests/Domain/data/tldinfo_com.json @@ -466,7 +466,7 @@ "validationCategory": "General", "wdrpNotifications": false, "errpNotifications": false, - "daysTransferLock": 0 + "transferLockDays": 0 }, "provider": "Verisign", "applicableFor": [ diff --git a/tests/Domain/data/tldinfo_nl.json b/tests/Domain/data/tldinfo_nl.json index 18846a3..9d128e7 100644 --- a/tests/Domain/data/tldinfo_nl.json +++ b/tests/Domain/data/tldinfo_nl.json @@ -125,7 +125,7 @@ }, "wdrpNotifications": false, "errpNotifications": false, - "daysTransferLock": 0 + "transferLockDays": 0 }, "provider": "Sidn", "applicableFor": [ From 9226659c7192f8f33c678bc891fe383c491d17b1 Mon Sep 17 00:00:00 2001 From: "jesse.berger" Date: Fri, 24 Apr 2026 10:33:38 +0200 Subject: [PATCH 4/4] RT-17796 Review comments & rebase --- src/Domain/TLDMetaData.php | 2 +- tests/Domain/data/tldinfo_nl.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Domain/TLDMetaData.php b/src/Domain/TLDMetaData.php index 968bb2e..fb26684 100644 --- a/src/Domain/TLDMetaData.php +++ b/src/Domain/TLDMetaData.php @@ -248,7 +248,7 @@ public static function fromArray(array $json): TLDMetaData $json['premiumSupport'], $json['wdrpNotifications'], $json['errpNotifications'], - $json['transferLockDays'] + $json['transferLockDays'] ?? null ); } diff --git a/tests/Domain/data/tldinfo_nl.json b/tests/Domain/data/tldinfo_nl.json index 9d128e7..68d8fd0 100644 --- a/tests/Domain/data/tldinfo_nl.json +++ b/tests/Domain/data/tldinfo_nl.json @@ -124,7 +124,7 @@ "organizationAllowed": true }, "wdrpNotifications": false, - "errpNotifications": false, + "errpNotifications": true, "transferLockDays": 0 }, "provider": "Sidn",