[Php81] Remove NullToStrictStringFuncCallArgRector from level set, skip array dim fetch args

Author: TomasVotruba

config/set/php81.php

@@ -11,7 +11,6 @@
 use Rector\Php81\Rector\Class_\MyCLabsClassToEnumRector;
 use Rector\Php81\Rector\Class_\SpatieEnumClassToEnumRector;
 use Rector\Php81\Rector\FuncCall\NullToStrictIntPregSlitFuncCallLimitArgRector;
-use Rector\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector;
 use Rector\Php81\Rector\MethodCall\MyCLabsMethodCallToEnumConstRector;
 use Rector\Php81\Rector\MethodCall\RemoveReflectionSetAccessibleCallsRector;
 use Rector\Php81\Rector\MethodCall\SpatieEnumMethodCallToEnumConstRector;
@@ -28,7 +27,6 @@
         ReadOnlyPropertyRector::class,
         SpatieEnumClassToEnumRector::class,
         SpatieEnumMethodCallToEnumConstRector::class,
-        NullToStrictStringFuncCallArgRector::class,
         NullToStrictIntPregSlitFuncCallLimitArgRector::class,
 
         ArrayToFirstClassCallableRector::class,

rules-tests/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector/Fixture/skip_array_dim_fetch_key.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector\Fixture;
+
+final class SkipArrayDimFetchKey
+{
+    public function run(array $data)
+    {
+        return str_replace('a', 'b', $data['key']);
+    }
+}

rules/Php81/NodeManipulator/NullToStrictStringIntConverter.php

@@ -6,6 +6,7 @@
 
 use PhpParser\Node\Arg;
 use PhpParser\Node\Expr;
+use PhpParser\Node\Expr\ArrayDimFetch;
 use PhpParser\Node\Expr\Cast\Int_ as CastInt_;
 use PhpParser\Node\Expr\Cast\String_ as CastString_;
 use PhpParser\Node\Expr\FuncCall;
@@ -120,6 +121,11 @@ public function convertIfNull(
 
     private function shouldSkipValue(Expr $expr, Scope $scope, bool $isTrait, string $targetType): bool
     {
+        // array dim fetch value is mixed, null is not known - skip to avoid wrong (string) cast
+        if ($expr instanceof ArrayDimFetch) {
+            return true;
+        }
+
         if ($this->isPropertyFetchOnClassWithMagicGet($expr)) {
             return true;
         }