RemoveUnusedPrivateMethodRector removes used method

[jlherren]

Bug Report

Subject	Details
Rector version	last dev-main
Installed as	composer dependency

Minimal PHP Code Causing Issue

See https://getrector.com/demo/07d5cff5-af68-474a-b118-69b15b6f1d6f

<?php

declare(strict_types=1);

namespace Bug;

final class Bug {
    public function getString(): string {
        return $this->getNull() ?? 'Hey';
    }

    private function getNull(): ?string {
        return null;
    }
}

Responsible rules

• RemoveUnusedPrivateMethodRector

Expected Behavior

The method should not be removed, as it is actually used.

[samsonasik]

@jlherren the new PHPStan 2.1.35 cause new issue seems due to change behaviour of PHPStan\Analyser\NodeScopeResolver, see related PRs and issue:

• 2.1.34 (working) : [test] Test pin PHPStan 2.1.34 (working) rector-downgrade-php#359
• 2.1.35 (not working): [test] Test bump PHPStan 2.1.35 (not working) rector-downgrade-php#360
• Bump to PHPStan ^2.1.35 rector-src#7847
• PHPStan 2.1.35 cause error on rector-downgrade-php phpstan/phpstan#13992

The failing test case already reported to phpstan :)

• [PHPStan 2.1.35] Add failing test where original Node not processed under VirtualNode on NodeScopeResolver::processNodes() phpstan/phpstan-src#4795

You can temporary pin rector/rector to 2.3.2 and phpstan/phpstan to 2.1.34 for now :)

[samsonasik]

I just pinned to phpstan/phpstan 2.1.34 on website, and it correctly skipped :)

https://getrector.com/demo/ae11b7e3-6269-46f9-accb-bb174170d6f7

You can temporary pin rector/rector to 2.3.2 and phpstan/phpstan to 2.1.34 for now :)

[samsonasik]

I am closing it as know issue on phpstan 2.1.35, and can wait next release fix with temporary pin to 2.1.34 :)

Ondre already aware of it:

• PHPStan 2.1.35 cause error on rector-downgrade-php phpstan/phpstan#13992 (comment)

[samsonasik]

Released Rector 2.3.4 with bump requirement to PHPStan 2.1.36

https://github.com/rectorphp/rector/releases/tag/2.3.4

[jlherren]

Thanks for the info. Unfortunately I can't switch to phpstan 2.1.34 because it's broken in a different way that was fixed in 2.1.35 and reverted again in 2.1.36. What a mess! 😆

But it's fine, I just excluded this rule from the one affected file for now.