Apply `RemoveNullArgOnNullDefaultParamRector` after `AddNameToNullArgumentRector` has been applied if `deadCode: true`

[u01jmg3]

Feature Request

RE: rectorphp/rector-src#8000 (comment)

It would be useful if RemoveNullArgOnNullDefaultParamRector could run after AddNameToNullArgumentRector, when the deadCode set is enabled.

Example

Currently, AddNameToNullArgumentRector transforms:

-$table->addRow(null, $styles['cant-split']);
+$table->addRow(height: null, style: $styles['cant-split']);

It would be beneficial if this could be further reduced (when deadCode is enabled) to:

-$table->addRow(height: null, style: $styles['cant-split']);
+$table->addRow(style: $styles['cant-split']);

(Reference: https://github.com/PHPOffice/PHPWord/blob/master/src/PhpWord/Element/Table.php#L67)

---

Note

This behaviour could potentially also apply to AddNameToBooleanArgumentRector, if a corresponding RemoveBooleanArgOnBooleanDefaultParamRector existed.

[samsonasik]

Could you create failing test case under tests/Issues ?

https://github.com/rectorphp/rector-src/tree/main/tests/Issues

with combine some rules? Thank you.

[calebdw]

This solely has to do with how you've ordered the rules in your rector.php config---since the new argument rules are not part of any default set

[TomasVotruba]

It might be useful to create a new set called "namedArgs" that would group all of these changes under one set. To avoid nitpicking various rules from different set names, some optional, a simply deliver the value user asks for. Thoughts?

[u01jmg3]

This solely has to do with how you've ordered the rules in your rector.php config---since the new argument rules are not part of any default set

I tried ordering my config in various ways, realising your 2 new rules are opt-in and not part of a set, but couldn't get the desired output. Maybe having a new set is the answer.

[calebdw]

Sounds good to me, there's more named arguments rules that I want to create

[TomasVotruba]

@calebdw Here we go: rectorphp/rector-src#8013