RHIDP-12635: Flavours for Operator#2165
Conversation
PR Build ResultsBuild passed -- 34/34 titles | 78s Content Quality AssessmentCQA Report
SummaryChecks: 19 total, 19 pass, 0 fail 19 checks: 19 pass, 0 fail Run Updated 2026-05-21 18:48:43 UTC |
1e64f41 to
c7209c7
Compare
c7209c7 to
7026d66
Compare
7026d66 to
36e22e9
Compare
2a4f27b to
5768588
Compare
5768588 to
613f130
Compare
613f130 to
b014e02
Compare
b014e02 to
a98c6ca
Compare
a98c6ca to
9c6b785
Compare
9c6b785 to
486dd96
Compare
486dd96 to
17c85cb
Compare
There was a problem hiding this comment.
@jmagak I was asked by @Jdubrick to take a look, but to some degree, at least some of my review comments are catching up with things that happened after I provided him some assistance
hopefully when @Jdubrick has a chance to look, along with perhaps @gazarenkov , they can chime in and let me know if my understanding is out of date or not
| Complete the following steps from that procedure: | ||
| + | ||
| . Create the {lcs-name} ({lcs-short}) ConfigMap (`lightspeed-stack`) | ||
| . Create the {ls-short} ConfigMap (`lightspeed-app-config`) for plugin configurations |
There was a problem hiding this comment.
I don't see any refs in the manifests or docs related to a lightspeed-app-config @Jdubrick @gazarenkov
were there app-config.yaml changes needed for lightspeed I am forgetting?
There was a problem hiding this comment.
Shouldn't be any changes to the app-config for Lightspeed specifically, only thing would be the addition of Notebooks but that is its own doc
|
|
||
| [NOTE] | ||
| ==== | ||
| {ls-short} uses a bring-your-own-model (BYOM) architecture. You must provide your own LLM provider API endpoint and credentials. |
There was a problem hiding this comment.
@Jdubrick shouldn't there be some explanation of how the user influences the env var manipulation cited in the llama-stack-config ConfigMap over at https://github.com/redhat-developer/rhdh-operator/blob/main/config/profile/rhdh/default-config/flavours/lightspeed/configmap-files.yaml#L49-L74
There was a problem hiding this comment.
Yeah there should be, I know @pabel-rh has https://github.com/redhat-developer/red-hat-developers-documentation-rhdh/pull/2210/changes opened for other Lightspeed docs changes, and she covers the provider setup in those changes. @pabel-rh @jmagak I am inclined to leave it up to you two on how you want to handle this so we don't duplicate?
7fb96f3 to
5fd5934
Compare
5fd5934 to
32da3a4
Compare
32da3a4 to
89fdd72
Compare
89fdd72 to
09dbb0c
Compare
Jdubrick
left a comment
There was a problem hiding this comment.
Some small comments, mostly I think we should coordinate these changes with @pabel-rh because there is overlap. I wonder if it is best to direct to the dedicated section for configuring Lightspeed instead of having it mixed in with these docs?
|
|
||
| [NOTE] | ||
| ==== | ||
| {ls-short} uses a bring-your-own-model (BYOM) architecture. You must provide your own LLM provider API endpoint and credentials. |
There was a problem hiding this comment.
Yeah there should be, I know @pabel-rh has https://github.com/redhat-developer/red-hat-developers-documentation-rhdh/pull/2210/changes opened for other Lightspeed docs changes, and she covers the provider setup in those changes. @pabel-rh @jmagak I am inclined to leave it up to you two on how you want to handle this so we don't duplicate?
09dbb0c to
d1475a2
Compare
d1475a2 to
e44e80b
Compare
|
@gabemontero, Thanks again for the review. I appreciate your detailed feedback. |
|



IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.10, main
Issue: RHIDP-12635
Preview:
4. Automate environment provisioning with predefined Operator configurations
4.1. Pre-configured settings for common use cases
4.2. Deploy Red Hat Developer Hub for workflow automation