From 2c03a6b177cb671e645b5027c4ace1be3e8d18dc Mon Sep 17 00:00:00 2001 From: Armel Soro Date: Sun, 10 May 2026 23:49:18 +0200 Subject: [PATCH 1/2] feat(must-gather): grant controllerrevisions access for rollout history The rollout history collector uses `kubectl rollout history` on StatefulSets, which internally needs to list controllerrevisions in the apps API group. Without this permission, the command fails with a "forbidden" error when running as the must-gather service account. Add controllerrevisions to the apps apiGroup resources in both the ClusterRole and namespace-scoped Role templates. Assisted-by: Claude --- charts/must-gather/templates/clusterrbac.yaml | 2 +- charts/must-gather/templates/rbac.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/must-gather/templates/clusterrbac.yaml b/charts/must-gather/templates/clusterrbac.yaml index 37f956c6..0fba64fd 100644 --- a/charts/must-gather/templates/clusterrbac.yaml +++ b/charts/must-gather/templates/clusterrbac.yaml @@ -21,7 +21,7 @@ rules: resources: ["namespaces", "nodes"] verbs: ["get", "list"] - apiGroups: ["apps"] - resources: ["deployments", "replicasets", "statefulsets", "daemonsets"] + resources: ["deployments", "replicasets", "statefulsets", "daemonsets", "controllerrevisions"] verbs: ["get", "list"] {{- if .Values.rbac.rules.platform }} - apiGroups: ["config.openshift.io"] diff --git a/charts/must-gather/templates/rbac.yaml b/charts/must-gather/templates/rbac.yaml index 5d88b629..a3c71990 100644 --- a/charts/must-gather/templates/rbac.yaml +++ b/charts/must-gather/templates/rbac.yaml @@ -19,7 +19,7 @@ rules: verbs: ["get", "list"] {{- end }} - apiGroups: ["apps"] - resources: ["deployments", "replicasets", "statefulsets", "daemonsets"] + resources: ["deployments", "replicasets", "statefulsets", "daemonsets", "controllerrevisions"] verbs: ["get", "list"] {{- if .Values.rbac.rules.ingresses }} - apiGroups: ["networking.k8s.io"] From ca0cc4e480373861a74885d66a1d464d9f9bdd44 Mon Sep 17 00:00:00 2001 From: Armel Soro Date: Sun, 10 May 2026 23:52:04 +0200 Subject: [PATCH 2/2] bump chart version --- charts/must-gather/Chart.yaml | 2 +- charts/must-gather/README.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/charts/must-gather/Chart.yaml b/charts/must-gather/Chart.yaml index 557edadb..4c43f6ce 100644 --- a/charts/must-gather/Chart.yaml +++ b/charts/must-gather/Chart.yaml @@ -35,4 +35,4 @@ maintainers: # Versions are expected to follow Semantic Versioning (https://semver.org/) # Note that when this chart is published to https://github.com/openshift-helm-charts/charts # it will follow the RHDH versioning 1.y.z -version: 0.5.0 +version: 0.5.1 diff --git a/charts/must-gather/README.md b/charts/must-gather/README.md index 4ac87dab..d42e2e55 100644 --- a/charts/must-gather/README.md +++ b/charts/must-gather/README.md @@ -1,7 +1,7 @@ # Must Gather Chart for Red Hat Developer Hub (RHDH) -![Version: 0.5.0](https://img.shields.io/badge/Version-0.5.0-informational?style=flat-square) +![Version: 0.5.1](https://img.shields.io/badge/Version-0.5.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) A Helm chart for running the RHDH Must-Gather diagnostic tool on Kubernetes @@ -27,7 +27,7 @@ Kubernetes: `>= 1.27.0-0` ```console helm upgrade --install my-rhdh-must-gather redhat-developer-hub-must-gather \ --repo https://redhat-developer.github.io/rhdh-chart \ - --version 0.5.0 \ + --version 0.5.1 \ [--wait --timeout=$duration] ```