Skip to content

Commit 8799e6e

Browse files
committed
fix(browser-sdk): lower bulk queue failure logging
1 parent c986857 commit 8799e6e

6 files changed

Lines changed: 28 additions & 10 deletions

File tree

packages/browser-sdk/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@reflag/browser-sdk",
3-
"version": "1.4.6",
3+
"version": "1.4.7",
44
"packageManager": "yarn@4.1.1",
55
"license": "MIT",
66
"repository": {

packages/browser-sdk/src/bulkQueue.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ export class BulkQueue {
151151
try {
152152
res = await this.sendBulk(batch);
153153
} catch (error) {
154-
this.logger?.error("bulk request failed; dropping batch", {
154+
this.logger?.debug("bulk request failed; dropping batch", {
155155
error,
156156
batchSize: batch.length,
157157
});
@@ -190,7 +190,7 @@ export class BulkQueue {
190190
!this.lastDropErrorAt ||
191191
now - this.lastDropErrorAt >= DROP_ERROR_THROTTLE_MS
192192
) {
193-
this.logger?.error("bulk queue dropped events due to max size", {
193+
this.logger?.debug("bulk queue dropped events due to max size", {
194194
droppedEvents: this.droppedSinceLastError,
195195
totalDroppedEvents: this.totalDroppedEvents,
196196
queueSize: this.queue.length + this.getInFlightBatchSize(),

packages/browser-sdk/test/bulkQueue.test.ts

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,14 @@ describe("BulkQueue", () => {
8282
await vi.advanceTimersByTimeAsync(10);
8383
expect(sendBulk).toHaveBeenCalledTimes(1);
8484
expect(await queue.size()).toBe(0);
85-
expect(logger.error).toHaveBeenCalledWith(
85+
expect(logger.debug).toHaveBeenCalledWith(
8686
"bulk request failed; dropping batch",
8787
expect.objectContaining({
8888
error: expect.any(Error),
8989
batchSize: 1,
9090
}),
9191
);
92+
expect(logger.error).not.toHaveBeenCalled();
9293
});
9394

9495
it("drops 4xx responses, logs error, and does not retry", async () => {
@@ -237,9 +238,16 @@ describe("BulkQueue", () => {
237238
resolveSend = resolve;
238239
}),
239240
);
241+
const logger = {
242+
debug: vi.fn(),
243+
info: vi.fn(),
244+
warn: vi.fn(),
245+
error: vi.fn(),
246+
};
240247
const queue = new BulkQueue(sendBulk, {
241248
flushDelayMs: 10_000,
242249
maxSize: 2,
250+
logger,
243251
});
244252

245253
await queue.enqueue(userEvent);
@@ -249,6 +257,16 @@ describe("BulkQueue", () => {
249257
expect(await queue.size()).toBe(2);
250258
expect(sendBulk).toHaveBeenCalledTimes(1);
251259
expect(sendBulk).toHaveBeenCalledWith([userEvent, companyEvent]);
260+
expect(logger.debug).toHaveBeenCalledWith(
261+
"bulk queue dropped events due to max size",
262+
expect.objectContaining({
263+
droppedEvents: 1,
264+
totalDroppedEvents: 1,
265+
queueSize: 2,
266+
maxSize: 2,
267+
}),
268+
);
269+
expect(logger.error).not.toHaveBeenCalled();
252270

253271
resolveSend?.(new Response("", { status: 200 }));
254272
});

packages/openfeature-browser-provider/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@reflag/openfeature-browser-provider",
3-
"version": "1.3.4",
3+
"version": "1.3.5",
44
"packageManager": "yarn@4.1.1",
55
"license": "MIT",
66
"repository": {
@@ -35,7 +35,7 @@
3535
}
3636
},
3737
"dependencies": {
38-
"@reflag/browser-sdk": "1.4.6"
38+
"@reflag/browser-sdk": "1.4.7"
3939
},
4040
"devDependencies": {
4141
"@openfeature/core": "1.5.0",

packages/react-sdk/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@reflag/react-sdk",
3-
"version": "1.4.6",
3+
"version": "1.4.7",
44
"license": "MIT",
55
"repository": {
66
"type": "git",
@@ -37,7 +37,7 @@
3737
}
3838
},
3939
"dependencies": {
40-
"@reflag/browser-sdk": "1.4.6"
40+
"@reflag/browser-sdk": "1.4.7"
4141
},
4242
"peerDependencies": {
4343
"react": "*",

packages/vue-sdk/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@reflag/vue-sdk",
3-
"version": "1.3.4",
3+
"version": "1.3.5",
44
"license": "MIT",
55
"repository": {
66
"type": "git",
@@ -35,7 +35,7 @@
3535
}
3636
},
3737
"dependencies": {
38-
"@reflag/browser-sdk": "1.4.6"
38+
"@reflag/browser-sdk": "1.4.7"
3939
},
4040
"peerDependencies": {
4141
"vue": "^3.0.0"

0 commit comments

Comments
 (0)