From d40353a4622f24a22ad616061c90c4905b064055 Mon Sep 17 00:00:00 2001 From: calebkeene Date: Fri, 26 Nov 2021 09:40:45 -0600 Subject: [PATCH 1/3] enable passing of cucumber runtime args --- lib/test_boosters/boosters/cucumber.rb | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/lib/test_boosters/boosters/cucumber.rb b/lib/test_boosters/boosters/cucumber.rb index f76b076..1d72af8 100644 --- a/lib/test_boosters/boosters/cucumber.rb +++ b/lib/test_boosters/boosters/cucumber.rb @@ -5,7 +5,7 @@ class Cucumber < Base FILE_PATTERN = "features/**/*.feature".freeze def initialize - super(FILE_PATTERN, nil, split_configuration_path, "bundle exec cucumber") + super(FILE_PATTERN, nil, split_configuration_path, "bundle exec #{command}") end def before_job @@ -32,6 +32,15 @@ def split_configuration_path ENV["CUCUMBER_SPLIT_CONFIGURATION_PATH"] || "#{ENV["HOME"]}/cucumber_split_configuration.json" end + private + + def command + if ENV["CUCUMBER_ARGS"] + "cucumber #{ENV["CUCUMBER_ARGS"]}" + else + "cucumber" + end + end end end end From 374d602d8477143c13e8b708b4c4283343e054d1 Mon Sep 17 00:00:00 2001 From: calebkeene Date: Sat, 27 Nov 2021 09:10:54 -0600 Subject: [PATCH 2/3] make the linter happy --- lib/test_boosters/boosters/cucumber.rb | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/lib/test_boosters/boosters/cucumber.rb b/lib/test_boosters/boosters/cucumber.rb index 1d72af8..2eb551a 100644 --- a/lib/test_boosters/boosters/cucumber.rb +++ b/lib/test_boosters/boosters/cucumber.rb @@ -5,7 +5,7 @@ class Cucumber < Base FILE_PATTERN = "features/**/*.feature".freeze def initialize - super(FILE_PATTERN, nil, split_configuration_path, "bundle exec #{command}") + super(FILE_PATTERN, nil, split_configuration_path, "bundle exec #{command} #{ENV['CUCUMBER_ARGS']}") end def before_job @@ -31,16 +31,6 @@ def report_path def split_configuration_path ENV["CUCUMBER_SPLIT_CONFIGURATION_PATH"] || "#{ENV["HOME"]}/cucumber_split_configuration.json" end - - private - - def command - if ENV["CUCUMBER_ARGS"] - "cucumber #{ENV["CUCUMBER_ARGS"]}" - else - "cucumber" - end - end end end end From 17d436c6d6753f9f081d800f7375a872d78d5a68 Mon Sep 17 00:00:00 2001 From: calebkeene Date: Sat, 27 Nov 2021 09:11:46 -0600 Subject: [PATCH 3/3] fix woopsi --- lib/test_boosters/boosters/cucumber.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/test_boosters/boosters/cucumber.rb b/lib/test_boosters/boosters/cucumber.rb index 2eb551a..0ab5928 100644 --- a/lib/test_boosters/boosters/cucumber.rb +++ b/lib/test_boosters/boosters/cucumber.rb @@ -5,7 +5,7 @@ class Cucumber < Base FILE_PATTERN = "features/**/*.feature".freeze def initialize - super(FILE_PATTERN, nil, split_configuration_path, "bundle exec #{command} #{ENV['CUCUMBER_ARGS']}") + super(FILE_PATTERN, nil, split_configuration_path, "bundle exec cucumber #{ENV['CUCUMBER_ARGS']}") end def before_job