Skip to content

Remove anyhow from re_ros_msg and re_arrow_util#12702

Open
emadak47 wants to merge 4 commits into
rerun-io:mainfrom
emadak47:anyhow-utils-crates
Open

Remove anyhow from re_ros_msg and re_arrow_util#12702
emadak47 wants to merge 4 commits into
rerun-io:mainfrom
emadak47:anyhow-utils-crates

Conversation

@emadak47
Copy link
Copy Markdown
Contributor

Related

What

  • removed anyhow from public fns in utils/ crates

@emadak47 emadak47 changed the title Remove anyhow from re_ros_msg and re_arrow_util` Remove anyhow from re_ros_msg and re_arrow_util Mar 23, 2026
Copy link
Copy Markdown
Member

@grtlr grtlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! The motivation behind

is to have more structured error reporting that can replace the functionality provided by anyhow while allowing downstream processing. Yet this PR does not add any structure beyond the single variant ArrayComparisonError.

For example, I would expect an Error::ChildCountMismatch (or similar) variant in re_arrow_util. The ROS-related errors go into the right direction.

@grtlr grtlr linked an issue Mar 24, 2026 that may be closed by this pull request
@emadak47
Copy link
Copy Markdown
Contributor Author

thank you for the feedback.

originally, I focused on current usage; since no callers match on variants, I went for a simple unit struct ArrayComparisonError. But that's not better than anyhow::Error, it's a string with a different hat.

I've added as many error variants as I deemed necessary, reducing further would lose meaningful distinctions, but I'm happy to hear your opinion if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace anyhow with thiserror in libraries

2 participants