Enable clippy::iter_over_hash_type in remaining viewer crates#12705
Open
emadak47 wants to merge 1 commit into
Open
Enable clippy::iter_over_hash_type in remaining viewer crates#12705emadak47 wants to merge 1 commit into
clippy::iter_over_hash_type in remaining viewer crates#12705emadak47 wants to merge 1 commit into
Conversation
emadak47
commented
Mar 24, 2026
Comment on lines
+221
to
+223
| { | ||
| re_log::error!(%err, ?path, "couldn't watch imported dependency"); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
if one path fails, the set of paths watched before the failure depends on iteration order, so I replaced with error logging which matches the pattern at line 279
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
clippy::iter_over_hash_typelint #6198What
#![warn(clippy::iter_over_hash_type)]in 17 viewer cratesre_renderer/src/file_server.rswhere?made the iteration order-dependent