From a1f9fb2a0dd77cb1448bb8e679928f383a4dd2ca Mon Sep 17 00:00:00 2001 From: nojaf Date: Mon, 18 Aug 2025 14:58:24 +0200 Subject: [PATCH 1/2] Correct get binding --- src/FetchAPI/FormData.res | 10 ++++++++-- tests/FetchAPI/FormData__test.res | 4 ++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/FetchAPI/FormData.res b/src/FetchAPI/FormData.res index d51b0233..d2517056 100644 --- a/src/FetchAPI/FormData.res +++ b/src/FetchAPI/FormData.res @@ -31,13 +31,13 @@ external delete: (formData, string) => unit = "delete" [Read more on MDN](https://developer.mozilla.org/docs/Web/API/FormData/get) */ @send -external get: (formData, string) => string = "get" +external get: (formData, string) => null = "get" /** [Read more on MDN](https://developer.mozilla.org/docs/Web/API/FormData/get) */ @send -external getFile: (formData, string) => file = "get" +external getFile: (formData, string) => null = "get" /** [Read more on MDN](https://developer.mozilla.org/docs/Web/API/FormData/getAll) @@ -51,6 +51,12 @@ external getAll: (formData, string) => array = "getAll" @send external has: (formData, string) => bool = "has" +/** +[Read more on MDN](https://developer.mozilla.org/docs/Web/API/FormData/keys) +*/ +@send +external keys: formData => Iterator.t = "keys" + /** [Read more on MDN](https://developer.mozilla.org/docs/Web/API/FormData/set) */ diff --git a/tests/FetchAPI/FormData__test.res b/tests/FetchAPI/FormData__test.res index 743defc1..28890dc9 100644 --- a/tests/FetchAPI/FormData__test.res +++ b/tests/FetchAPI/FormData__test.res @@ -3,5 +3,5 @@ external myForm: DOMAPI.htmlFormElement = "myForm" let formData = FormData.make(~form=myForm) -let phone = formData->FormData.get("phone") -let image = formData->FormData.getFile("image") +let phone : null = formData->FormData.get("phone") +let image : null = formData->FormData.getFile("image") From 9ac6c59985698ca9f57ae2746314f98b38aefac4 Mon Sep 17 00:00:00 2001 From: nojaf Date: Mon, 18 Aug 2025 14:58:54 +0200 Subject: [PATCH 2/2] Format all ReScript files --- src/WebWorkersAPI.res | 3 +-- src/WebWorkersAPI/SharedWorker.res | 4 +--- src/WebWorkersAPI/SharedWorkerGlobalScope.res | 9 ++------- 3 files changed, 4 insertions(+), 12 deletions(-) diff --git a/src/WebWorkersAPI.res b/src/WebWorkersAPI.res index 66770159..3fb24122 100644 --- a/src/WebWorkersAPI.res +++ b/src/WebWorkersAPI.res @@ -52,7 +52,6 @@ type workerType = | @as("classic") Classic | @as("module") Module - /** An object containing option properties that can set when creating the object instance. */ type workerOptions = { @@ -71,5 +70,5 @@ the complete list of functions available to workers. @editor.completeFrom(SharedWorkerGlobalScope) type sharedWorkerGlobalScope = { ...workerGlobalScope, - name: option + name: option, } diff --git a/src/WebWorkersAPI/SharedWorker.res b/src/WebWorkersAPI/SharedWorker.res index 105e44ae..d4fc5280 100644 --- a/src/WebWorkersAPI/SharedWorker.res +++ b/src/WebWorkersAPI/SharedWorker.res @@ -1,9 +1,7 @@ open ChannelMessagingAPI open WebWorkersAPI -include EventTarget.Impl({ - type t = sharedWorker -}) +include EventTarget.Impl({type t = sharedWorker}) /** `make(string)` diff --git a/src/WebWorkersAPI/SharedWorkerGlobalScope.res b/src/WebWorkersAPI/SharedWorkerGlobalScope.res index bd603c1f..bcc02b00 100644 --- a/src/WebWorkersAPI/SharedWorkerGlobalScope.res +++ b/src/WebWorkersAPI/SharedWorkerGlobalScope.res @@ -5,9 +5,7 @@ module Impl = ( type t }, ) => { - include WorkerGlobalScope.Impl({ - type t = T.t - }) + include WorkerGlobalScope.Impl({type t = T.t}) /** `close(sharedWorkerGlobalScope)` @@ -26,7 +24,4 @@ self -> SharedWorkerGlobalScope.close external close: T.t => unit = "close" } -include Impl({ - type t = sharedWorkerGlobalScope -}) - +include Impl({type t = sharedWorkerGlobalScope})