Regression after JSX3 removal

[cknitt]

It seems something broke on master with the JSX3 cleanup PR #7072. I forgot to test against a real-world project before merging.

I have a large project with several yarn workspace packages and lots of dependencies.
Only the top-level rescript.json has

  "jsx": {
    "version": 4,
    "mode": "automatic"
  },

but not the other workspace packages or the dependencies.

It seems that the default of JSX 4 was previously inherited from the root rescript.json, but now that's not the case anymore.
So the project only builds if I add the above configuration to the rescript.json of all workspace packages and dependencies.

@mununki Could you have a look at this? And it would be great to have a test in build_tests to verify that the inheritance of the JSX setting works.

[cristianoc]

It might default to off instead of inheriting in subprojects.
Btw should it ever be off?
I would leave it always on and only make the mode configurable.
Thoughts?

[cristianoc]

In any case the config mode should be inherited.

[mununki]

Previously, if a project had JSX-related configurations, the dependent packages would inherit those JSX settings even if they didn't have their own JSX configurations, right? Do you hope this will continue to be the default behavior in the future?

[cknitt]

Do you hope this will continue to be the default behavior in the future?

Yes, the dependent packages should continue to inherit the JSX settings.

I would leave it always on and only make the mode configurable.
Thoughts?

Sounds good to me. Cannot really think of any major downside. It will be superfluous on non-React/-JSX projects, but it shouldn't do any harm there either.

[mununki]

• JSX setting is inherited to the subprojects as default
• The mode is configurable in the subprojects

Do I understand correctly?

[cknitt]

@mununki We want to restore the previous behavior regarding inheritance that we had before the JSX3 removal PR.
I think it was like you described it here, but better double check.

[mununki]

@mununki We want to restore the previous behavior regarding inheritance that we had before the JSX3 removal PR. I think it was like you described it here, but better double check.

Got it.