Skip to content

Checking scores in sh_check.py #1

@v-v

Description

@v-v

Hello,

it'd seem to me that lines 172 and 173 of sh_check.py shouldn't be like:

if isScore(field[7]):
        errors.append(reportError(lineno, "Invalid score: " + field[6])) 

but more likely the following:

if not isScore(field[6]):
        errors.append(reportError(lineno, "Invalid score: " + field[6])) 

(I think that you are checking the wrong field to find the score and then adding an error if the score is correct)
This is for the hyperlinking task, I didn't check if the searching part has the same problem.

Another thing, in utils.py, you define isScore() two times, on line 63 and 340, which makes predicting which one will be called more difficult and the code redundant.

Hope it helps,
Vedran

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions